From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90066 invoked by alias); 5 Sep 2017 08:58:29 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 89297 invoked by uid 89); 5 Sep 2017 08:58:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:212.227.17.22, Hx-spam-relays-external:!192.168.1.4!, H*r:ip*192.168.1.4, H*RU:!192.168.1.4! X-Spam-User: qpsmtpd, 2 recipients X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.17.22) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Sep 2017 08:58:22 +0000 Received: from [192.168.1.4] ([185.58.161.191]) by mail.gmx.com (mrgmx101 [212.227.17.174]) with ESMTPSA (Nemesis) id 0MVZuV-1dyh9H3aOt-00Yyck; Tue, 05 Sep 2017 10:58:13 +0200 Subject: Re: [binutils-gdb] Enable support for x86 debug registers on NetBSD. To: John Baldwin References: <20170905024337.88051.qmail@sourceware.org> From: Kamil Rytarowski Cc: gdb@sourceware.org, coypu@sdf.org Message-ID: <53223a37-4aee-76f1-4b5e-131f52cafab0@gmx.com> Date: Tue, 05 Sep 2017 08:58:00 -0000 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170905024337.88051.qmail@sourceware.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xdaf7IXVE3ww2tLLXTWWvUaDO7G2sq4Od" X-UI-Out-Filterresults: notjunk:1;V01:K0:GTLUDYS7QPc=:HftfkGX6hPQFdg6KHl4L/L JOsaJIqDzVm4y1C204VqeYifo4wVd8Ti+F8p6PypCMyM8GFVxsVSA/koVWWrNxEbVd2/NXCOH UmyBTd3TnIWi/IUTGbN4iVfUsvQYxGFImQzwBNnqIpKoMinyhohE7ATinNHDsOF1pOj7+8jig kl0byuZNuzNZiQemIZH8fxWV+jztTmDg3nLH2IUWVHlWQutJEEN8Z2JSRfokeBi7yGMfQCXpY 0OeVLIxoazzFWc9CN2oiKNSuIFn9ErH0ytgesoVH7CjpL/9/zVtY5UNMZ/sm/Q56KK7niJb7H i/+tavAdtzlnAHxc0LR7bLonJ4J5qLKu8CeebFXtJsLCNe5OKgjbXMX2n+mYpHY2sOSwIHM7E D/LMmNYWaSXjRdX/to9iNDS16clRmn/48dYQD9dUWYFvmJnQcI4OEbi8Dcvr5j4B64XeEgaDq NQPWnf9+NBL4vDsFCB70xPESXbZxDTqWickdUDT1bcK65JrwkmyamoHUnIYuZlW7CCKiGugDJ MCNX2aDDPasRXuTXu8VHiSkLB3jhr1tkwYexiFF0Q+qp5tHJzEEeA/nunj1l1FnK8Xbkmdd3K cgq1UNzdB0jM/xrBnWjs5KRDtQKNrWgAEjCGvPLbrh2PzzDgND3U6upYKwIa0jWWwDB6MCBfA t7axL8OZASX8coNyzPpYn63bRUZ04ejCrrgJD/vyYtXkwt0euvN9N4sh7plWNSlfJNquK1qbS e1GecqCVXUD2TQNBolZ1dSDQ0sR5zWrsVAAIsXw5jgoZaz0/gq37m9JRjVBbbYrcTlGnpVM77 MEnfdt4VFG3JvC1/OEKGnnROIKa3A== X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00002.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xdaf7IXVE3ww2tLLXTWWvUaDO7G2sq4Od Content-Type: multipart/mixed; boundary="oJFSwRbCGlGq3qLIU5MUCUsEtLftjwJTc"; protected-headers="v1" From: Kamil Rytarowski To: John Baldwin Cc: gdb@sourceware.org, coypu@sdf.org Message-ID: <53223a37-4aee-76f1-4b5e-131f52cafab0@gmx.com> Subject: Re: [binutils-gdb] Enable support for x86 debug registers on NetBSD. References: <20170905024337.88051.qmail@sourceware.org> In-Reply-To: <20170905024337.88051.qmail@sourceware.org> --oJFSwRbCGlGq3qLIU5MUCUsEtLftjwJTc Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-length: 1066 On 05.09.2017 04:43, John Baldwin wrote: > -/* Not all versions of FreeBSD/i386 that support the debug registers > - have this macro. */ > +/* Helper macro to access debug register X. FreeBSD/amd64 and modern > + versions of FreeBSD/i386 provide this macro in system headers. Define > + a local version for systems that do not provide it. */ > #ifndef DBREG_DRX > +#ifdef __NetBSD__ > +#define DBREG_DRX(d, x) ((d)->dr[x]) > +#else > #define DBREG_DRX(d, x) ((&d->dr0)[x]) > #endif > +#endif >=20=20 > static unsigned long > x86bsd_dr_get (ptid_t ptid, int regnum) >=20 Do we support FreeBSD releases developed in year 2002? This macro has point for such old systems as it keeps compat between old and new structure layout. "bsdphk committed on 20 Oct 2002" https://github.com/freebsd/freebsd/commit/6c70e7ba980490dd092e728144518733e= ed32383 I think we are now ready to just drop it entirely. I've deliberately decided to not include them on NetBSD. Another place that it keeps dusting is in wine. Regardless thanks for committing the patches! --oJFSwRbCGlGq3qLIU5MUCUsEtLftjwJTc-- --xdaf7IXVE3ww2tLLXTWWvUaDO7G2sq4Od Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZrmTOAAoJEEuzCOmwLnZsOzAP/jCO//kPriaD/tf8XQoPGvwt PLvTpLc/K6e4D5EvX5Q6MHnuFEaFfXmJBx1DZ5boeg0HougNF1MmEJxhGWIE/+ct jE6czgGJvMrdd1LTW7Q70jbUXu3o0AI6+Jru4hcaCZtDIcNYS4FsVVZ1jSEA/fxf MqSdbGCiTqsyo8nKx4DMrkQQQUt4bpPhghqasLcSWm4iWI1e+EptXp108yJToLD4 rw8ZrIGjrqx9T4wIhQC6J6H8s6LzoHkK4rfHRIgt/P7HiI07HKZxFgp8SS9vovGL 25yyhoCnq13fDpcJLmC4OVc+V7WEgia+UP7TAJeDQVbQcPlIuC4BURIL8Qu/lm3m +iMKZr8J4pMW8UBmS60ILf82DTLcyd7oHPbiH3c/uEyzjQaaA16Q0wS3w/Qjz+0B WylcwP0PVdJ6L/4fnyPeMJTIl+lrFVw47c/IWHj1JBSazR7OFyiqd3j2P1H4Wxbe TMLtuIWZ0rW66xZl36ZFcTwZ/mS1dXkvckfyGxn7w4mtmzd6wZkdEC6YkYKO51nJ y6pgGa1OxuKc8G17vtlE8nJ0ivqRMcTeFSgzkJi6Cs/WMsi1JJtVQzhF2yjx5sjV br4aMxJXXL7agN57TVZJTUQNjN+zndR7TYLAzKSm7SPbq9ZfkW12bnQjSRPuoReo glQJb0htODy4Hx2QbFlZ =mGlP -----END PGP SIGNATURE----- --xdaf7IXVE3ww2tLLXTWWvUaDO7G2sq4Od--