From: Pedro Alves <palves@redhat.com>
To: Christian Biesinger <cbiesinger@google.com>, gdb@sourceware.org
Subject: Re: Renaming .c files to .cc?
Date: Wed, 11 Dec 2019 10:59:00 -0000 [thread overview]
Message-ID: <617317be-2567-fd53-135d-8ed391ae1a86@redhat.com> (raw)
In-Reply-To: <CAPTJ0XEXR2Kb9CU1j17g9VE9fU07xsWHJSk4QiD1ma47F1TSsA@mail.gmail.com>
On 12/10/19 10:18 PM, Christian Biesinger via gdb wrote:
> Hello all,
>
> I was wondering what people's thoughts are on renaming the .c files to
> .cc, since they are in fact C++ code? (Only for files under gdb/)
>
> Advantages:
> - Easier for newcomers to see that the code is, in fact, C++
> - Editors will syntax highlight C++ keywords w/o having to be told
> that these files are C++
>
> On IRC it was mentioned that git may have issues with renames like
> that but I have found that "git log --follow" and such are doing a
> good job with that, at least as long as the same commit doesn't change
> the file too much while it is renamed, which I wouldn't expect to be a
> problem here.
>
> Thoughts?
My thoughts are that using .c instead of .cc is largely a minor
aesthetic issue, and that of all the things that might hinder someone
from seriously contributing to gdb, this has got to be at the bottom
of the list. It's one of those things that you might be surprised about,
and then once you learn it, it just fades into the background and you
barely remember it. We could just document it in some easier-to-find
place to eliminate the "surprise" effect and call it a day.
OTOH, renaming all the files has a recurring cost to people using git
tooling every day.
IMO, renaming the files has a disproportionate cost/benefit ratio.
I'm not terribly opposed, but I'm in the "prefer not" camp.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-12-11 10:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 22:19 Christian Biesinger via gdb
2019-12-11 0:42 ` Luis Machado
2019-12-11 1:27 ` Christian Biesinger via gdb
2019-12-11 1:33 ` Luis Machado
2019-12-11 2:24 ` Simon Marchi
2019-12-11 3:32 ` Eli Zaretskii
2019-12-11 23:00 ` Christian Biesinger via gdb
[not found] ` <838sni9ifm.fsf@gnu.org>
2019-12-14 18:20 ` Christian Biesinger via gdb
2019-12-11 10:59 ` Pedro Alves [this message]
2019-12-11 16:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=617317be-2567-fd53-135d-8ed391ae1a86@redhat.com \
--to=palves@redhat.com \
--cc=cbiesinger@google.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox