From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65456 invoked by alias); 11 Dec 2019 10:59:17 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 65448 invoked by uid 89); 11 Dec 2019 10:59:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=terribly, day X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Dec 2019 10:59:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576061954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bzi0ZpQRyx7zpPwoGzXhdtYlIGuFNKgx2lj6Hr3rnpE=; b=dGj9wgxVOWLPP70+vgrwKcQyYXbFNSj5uz2vPNDwJUfyqjmxXSgfdTyRfTz9iVRK0w4af2 7JvsBCGR7Gk7kt+J1dl7UaUGBO2bQyzJDzF5GyhAyhAhN1dBPsEbZCiVnhfxPr6pk24J3Q uJBFdpFtbBh5q1MMWnKXib1I/Y3o2XY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-1-npMdgsT3NbKMvSyHgpq9bA-1; Wed, 11 Dec 2019 05:59:10 -0500 Received: by mail-wm1-f71.google.com with SMTP id m133so764774wmf.2 for ; Wed, 11 Dec 2019 02:59:10 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id t8sm1772950wrp.69.2019.12.11.02.59.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2019 02:59:08 -0800 (PST) Subject: Re: Renaming .c files to .cc? To: Christian Biesinger , gdb@sourceware.org References: From: Pedro Alves Message-ID: <617317be-2567-fd53-135d-8ed391ae1a86@redhat.com> Date: Wed, 11 Dec 2019 10:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg00007.txt.bz2 On 12/10/19 10:18 PM, Christian Biesinger via gdb wrote: > Hello all, > > I was wondering what people's thoughts are on renaming the .c files to > .cc, since they are in fact C++ code? (Only for files under gdb/) > > Advantages: > - Easier for newcomers to see that the code is, in fact, C++ > - Editors will syntax highlight C++ keywords w/o having to be told > that these files are C++ > > On IRC it was mentioned that git may have issues with renames like > that but I have found that "git log --follow" and such are doing a > good job with that, at least as long as the same commit doesn't change > the file too much while it is renamed, which I wouldn't expect to be a > problem here. > > Thoughts? My thoughts are that using .c instead of .cc is largely a minor aesthetic issue, and that of all the things that might hinder someone from seriously contributing to gdb, this has got to be at the bottom of the list. It's one of those things that you might be surprised about, and then once you learn it, it just fades into the background and you barely remember it. We could just document it in some easier-to-find place to eliminate the "surprise" effect and call it a day. OTOH, renaming all the files has a recurring cost to people using git tooling every day. IMO, renaming the files has a disproportionate cost/benefit ratio. I'm not terribly opposed, but I'm in the "prefer not" camp. Thanks, Pedro Alves