Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: "Christian Biesinger via gdb" <gdb@sourceware.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: Renaming .c files to .cc?
Date: Sat, 14 Dec 2019 18:20:00 -0000	[thread overview]
Message-ID: <CAPTJ0XGhTmGLvWQFsyLYpig8wMPV2dN3JxfDoSf4ZmKHa+oDeQ@mail.gmail.com> (raw)
In-Reply-To: <838sni9ifm.fsf@gnu.org>

On Thu, Dec 12, 2019 at 1:17 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: Christian Biesinger <cbiesinger@google.com>
> > Date: Wed, 11 Dec 2019 17:59:39 -0500
> > Cc: gdb@sourceware.org, Pedro Alves <palves@redhat.com>
> >
> > > Not every Git command has a --follow option, so renaming files does
> > > have disadvantages in that area.
> >
> > Do you have a specific command in mind that doesn't? I haven't come
> > across that yet myself.
>
> Are you saying that every Git command supports that option?  I don't
> think so.

Sorry, that's not what I meant; I had never run into one where I
missed that option, and you sounded like you had one in mind, so I was
curious. I don't know either way if there are git commands that miss
that option.

BTW, there is a setting to make --follow the default. git config
--global log.follow true

> And even those who do support it impose limitations when it's used.
> For example,
>
>   $ git log file1 file2 ...
>
> works, but
>
>   $ git log --follow file1 file2 ...
>
> fails with an error message.  So many important forensic
> investigations limit you to single files when using --follow.

OK.

> > > Also, even with --follow, Git's tracking of renaming is heuristics,
> > > so it can fail.
> >
> > Technically correct, but not an issue in practice when files are being
> > renamed without changes, like they would be here.
>
> That's not guaranteed, because several files with similar contents can
> dupe the heuristics.
>
> Anyway, like Pedro said: the reasons for being in the "rather not"
> camp are not strong.

OK, I'll drop this.

Christian


  parent reply	other threads:[~2019-12-14 18:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 22:19 Christian Biesinger via gdb
2019-12-11  0:42 ` Luis Machado
2019-12-11  1:27   ` Christian Biesinger via gdb
2019-12-11  1:33     ` Luis Machado
2019-12-11  2:24 ` Simon Marchi
2019-12-11  3:32 ` Eli Zaretskii
2019-12-11 23:00   ` Christian Biesinger via gdb
     [not found]     ` <838sni9ifm.fsf@gnu.org>
2019-12-14 18:20       ` Christian Biesinger via gdb [this message]
2019-12-11 10:59 ` Pedro Alves
2019-12-11 16:35   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPTJ0XGhTmGLvWQFsyLYpig8wMPV2dN3JxfDoSf4ZmKHa+oDeQ@mail.gmail.com \
    --to=gdb@sourceware.org \
    --cc=cbiesinger@google.com \
    --cc=eliz@gnu.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox