From: Pawel Piech <pawel.piech@windriver.com>
To: gdb@sources.redhat.com
Subject: Re: MI non-stop mode spec
Date: Mon, 24 Mar 2008 17:22:00 -0000 [thread overview]
Message-ID: <47E7CA7B.2080309@windriver.com> (raw)
In-Reply-To: <18405.59380.664535.643670@kahikatea.snap.net.nz>
Hi Nick,
Thank you for the reply. I'm still rather curious what you, Vladimir,
and anyone else think of the rest of my suggestions.
Nick Roberts wrote:
> > I don't fully understand why disabling CLI commands is desired, but I'm
> > guessing it's because the CLI commands would still rely on the current
> > thread. If so, then keeping the MI protocol stateful would hopefully
> > address that concern and not force you to disable the CLI interface,
> > which would be unfortunate.
>
> It's probably not desired but it's certainly more effort. Perhaps the customer
> in question can be persuaded of it's value: it's certainly important for any
> frontend that wants to keep the console. This still provides access to a lot
> of funtionality in GDB that hasn't yet been properly implemented in MI.
>
I think it would be a great disservice to GDB to disable the console.
Even though the console in the IDE is pretty broken for the reasons you
mention, a lot of our Eclipse users still value it greatly, so fixing
it's interaction with MI would actually be very good for GDB.
> Currently commands like -break-insert gives synchronous MI output for the
> frontend to parse while the CLI command "break" issued under MI,
> "-interpreter-exec console break", say, just gives CLI output. I think this is
> the wrong approach and that -break-insert shouldn't generate the output
> directly but instead MI should generate event notifications informing the
> frontend of changes:
>
> =breakpoints-changed,...
>
> This could be done with observers like Vladimir has done for threads and
> would produce the same notifications regardless of whether the breakpoint
> was created with a CLI or MI command.
>
> Likewise with the new commands for non-stop mode
Thank you for the explanation. I agree. Currently MI lacks out of band
notifications for thread state changes (it has a running event only),
thread lifecycle events, memory changed events, registers changed
events, modules changed events, and as you mention above breakpoints
changed events. Like I said, I'm not familiar with GDB internals, but
since CLI has notifications for most of these I can't imagine it would
be that hard to add them to MI.
One note about the =breakpoints-changed proposed above. I think it
would be a mistake to just replace the ^done reply to
-break-insert/-break-remove with an event alone, because a client would
have no way of knowing whether an event was in response to that client's
request or another client's request. I.e. a client would not be able to
positively determine the ID of the breakpoint he just created. I see
two equally good ways to address this:
1) Add the =breakpoints-changed event in addition to the ^done with
breakpoint info, but the =breakpoints-changed would have to be sent
AFTER the ^done reply.
2) Allow clients to specify their own arbitrary ID for a breakpoint,
with an option such as -client-id="abc". Then have the
=breakpoints-changed event and other query commands echo the client-id
along with the regular breakpoint ID.
Cheers,
Pawel
next prev parent reply other threads:[~2008-03-24 15:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 2:49 Vladimir Prus
2008-03-19 6:26 ` Nick Roberts
2008-03-19 9:14 ` Vladimir Prus
2008-03-19 10:02 ` Nick Roberts
2008-03-19 11:10 ` Vladimir Prus
2008-03-19 12:30 ` Nick Roberts
2008-03-19 13:43 ` Vladimir Prus
2008-03-19 20:44 ` Michael Snyder
2008-03-19 11:20 ` Bob Rossi
2008-03-19 11:16 ` Bob Rossi
2008-03-19 12:01 ` Vladimir Prus
2008-03-19 13:50 ` Bob Rossi
2008-03-19 14:07 ` Vladimir Prus
2008-03-19 14:33 ` Bob Rossi
2008-03-19 16:09 ` Vladimir Prus
2008-03-20 18:22 ` Marc Khouzam
2008-03-20 20:02 ` Vladimir Prus
2008-03-21 9:11 ` Nick Roberts
2008-03-21 9:48 ` Vladimir Prus
2008-03-21 18:13 ` Nick Roberts
2008-03-22 0:33 ` Vladimir Prus
2008-03-23 4:41 ` Nick Roberts
2008-03-23 5:18 ` Vladimir Prus
2008-03-23 9:25 ` Nick Roberts
2008-03-24 5:44 ` Vladimir Prus
2008-03-24 7:05 ` Thread bound variable objects [was: Re: MI non-stop mode spec] Nick Roberts
2008-03-24 7:18 ` Vladimir Prus
2008-03-24 11:04 ` Nick Roberts
2008-03-24 14:38 ` Vladimir Prus
2008-03-25 6:28 ` Thread bound variable objects Nick Roberts
2008-03-25 11:34 ` Daniel Jacobowitz
2008-03-21 11:52 ` MI non-stop mode spec Vladimir Prus
2008-03-24 23:14 ` Daniel Jacobowitz
2008-03-25 17:46 ` Vladimir Prus
2008-03-22 17:33 ` Pawel Piech
2008-03-24 4:03 ` Nick Roberts
2008-03-24 17:22 ` Pawel Piech [this message]
2008-03-24 20:23 ` Vladimir Prus
2008-03-25 2:14 ` Nick Roberts
2008-03-24 18:38 ` Vladimir Prus
2008-03-24 21:25 ` Pawel Piech
2008-03-24 21:46 ` Vladimir Prus
2008-03-24 22:28 ` Pawel Piech
2008-03-25 12:30 ` Vladimir Prus
2008-03-25 18:30 ` Pawel Piech
2008-03-27 14:13 ` Vladimir Prus
2008-03-27 19:39 ` Pawel Piech
2008-03-25 21:28 ` Nick Roberts
2008-03-26 13:03 ` Pawel Piech
2008-03-25 1:00 ` Daniel Jacobowitz
2008-03-25 18:18 ` Pawel Piech
2008-03-30 21:36 ` Pawel Piech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E7CA7B.2080309@windriver.com \
--to=pawel.piech@windriver.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox