From: Will Deacon <will.deacon@arm.com>
To: Dave Martin <Dave.Martin@arm.com>
Cc: "Julien Grall" <julien.grall@arm.com>,
linux-arm-kernel@lists.infradead.org,
"Peter Maydell" <peter.maydell@linaro.org>,
gdb@sourceware.org, "Alan Hayward" <alan.hayward@arm.com>,
"Zhang Lei" <zhang.lei@jp.fujitsu.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 1/3] arm64/sve: Fix missing SVE/FPSIMD endianness conversions
Date: Thu, 13 Jun 2019 10:17:00 -0000 [thread overview]
Message-ID: <20190613101727.GE17331@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190613100031.GU28398@e103592.cambridge.arm.com>
On Thu, Jun 13, 2019 at 11:00:34AM +0100, Dave Martin wrote:
> On Wed, Jun 12, 2019 at 06:46:04PM +0100, Julien Grall wrote:
> > On 12/06/2019 17:00, Dave Martin wrote:
> > >diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h
> > >index 7b7ac0f..072ea1e 100644
> > >--- a/arch/arm64/include/uapi/asm/kvm.h
> > >+++ b/arch/arm64/include/uapi/asm/kvm.h
> > >@@ -260,6 +260,13 @@ struct kvm_vcpu_events {
> > > KVM_REG_SIZE_U256 | \
> > > ((i) & (KVM_ARM64_SVE_MAX_SLICES - 1)))
> > >+/*
> > >+ * Register values for KVM_REG_ARM64_SVE_ZREG(), KVM_REG_ARM64_SVE_PREG() and
> > >+ * KVM_REG_ARM64_SVE_FFR() and represented in memory in an endianness-
> >
> > NIT: s/and represented/are represented/ I think.
> >
> > >+ * invariant layout which differs from the layout used for the FPSIMD
> > >+ * V-registers on big-endian systems: see sigcontext.h for more explanaion.
> >
> > NIT: s/explanaion/explanation/
>
> Dang, the first of these two is quite confusing.
>
> I might send a fix for that, but I guess it's not urgent. Thanks for
> spotting it.
I've pushed an updated version out so hopefully no need to do anything more.
Will
next prev parent reply other threads:[~2019-06-13 10:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 16:00 [PATCH v2 0/3] arm64/sve: Fix mutating register endianness on big-endian Dave Martin
2019-06-12 16:01 ` [PATCH v2 3/3] arm64/sve: Fix a couple of magic numbers for the Z-reg count Dave Martin
2019-06-20 13:43 ` Julien Grall
2019-07-22 10:32 ` Catalin Marinas
2019-06-12 16:01 ` [PATCH v2 2/3] arm64/sve: Factor out FPSIMD to SVE state conversion Dave Martin
2019-06-20 13:45 ` Julien Grall
2019-07-22 10:31 ` Catalin Marinas
2019-06-12 16:01 ` [PATCH v2 1/3] arm64/sve: Fix missing SVE/FPSIMD endianness conversions Dave Martin
2019-06-12 17:29 ` Will Deacon
2019-06-12 17:46 ` Julien Grall
2019-06-13 10:00 ` Dave Martin
2019-06-13 10:17 ` Will Deacon [this message]
2019-06-13 10:20 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613101727.GE17331@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=Dave.Martin@arm.com \
--cc=alan.hayward@arm.com \
--cc=alex.bennee@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=gdb@sourceware.org \
--cc=julien.grall@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=peter.maydell@linaro.org \
--cc=zhang.lei@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox