From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86245 invoked by alias); 13 Jun 2019 10:17:33 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 86237 invoked by uid 89); 13 Jun 2019 10:17:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=H*M:20190613101727, urgent X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Jun 2019 10:17:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BB767367; Thu, 13 Jun 2019 03:17:30 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D41B33F694; Thu, 13 Jun 2019 03:19:12 -0700 (PDT) Date: Thu, 13 Jun 2019 10:17:00 -0000 From: Will Deacon To: Dave Martin Cc: Julien Grall , linux-arm-kernel@lists.infradead.org, Peter Maydell , gdb@sourceware.org, Alan Hayward , Zhang Lei , Catalin Marinas , Alex =?iso-8859-1?Q?Benn=E9e?= Subject: Re: [PATCH v2 1/3] arm64/sve: Fix missing SVE/FPSIMD endianness conversions Message-ID: <20190613101727.GE17331@fuggles.cambridge.arm.com> References: <1560355234-25516-1-git-send-email-Dave.Martin@arm.com> <1560355234-25516-2-git-send-email-Dave.Martin@arm.com> <771b0099-9217-4e55-b73a-b03434c61655@arm.com> <20190613100031.GU28398@e103592.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190613100031.GU28398@e103592.cambridge.arm.com> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () X-SW-Source: 2019-06/txt/msg00032.txt.bz2 On Thu, Jun 13, 2019 at 11:00:34AM +0100, Dave Martin wrote: > On Wed, Jun 12, 2019 at 06:46:04PM +0100, Julien Grall wrote: > > On 12/06/2019 17:00, Dave Martin wrote: > > >diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h > > >index 7b7ac0f..072ea1e 100644 > > >--- a/arch/arm64/include/uapi/asm/kvm.h > > >+++ b/arch/arm64/include/uapi/asm/kvm.h > > >@@ -260,6 +260,13 @@ struct kvm_vcpu_events { > > > KVM_REG_SIZE_U256 | \ > > > ((i) & (KVM_ARM64_SVE_MAX_SLICES - 1))) > > >+/* > > >+ * Register values for KVM_REG_ARM64_SVE_ZREG(), KVM_REG_ARM64_SVE_PREG() and > > >+ * KVM_REG_ARM64_SVE_FFR() and represented in memory in an endianness- > > > > NIT: s/and represented/are represented/ I think. > > > > >+ * invariant layout which differs from the layout used for the FPSIMD > > >+ * V-registers on big-endian systems: see sigcontext.h for more explanaion. > > > > NIT: s/explanaion/explanation/ > > Dang, the first of these two is quite confusing. > > I might send a fix for that, but I guess it's not urgent. Thanks for > spotting it. I've pushed an updated version out so hopefully no need to do anything more. Will