Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb@sourceware.org
Subject: Re: Trailing Whitespace
Date: Thu, 09 Jan 2014 15:01:00 -0000	[thread overview]
Message-ID: <20140109150145.GA3788@adacore.com> (raw)
In-Reply-To: <20140109145731.GA13720@localhost.localdomain>

> Also (and I am not sure if git can get around this somehow) whitespace
> cleanups tend to obliterate diffs/patches that were written before the
> cleanup took place.  This makes merging a massive pain.
> 
> So my 2 pence worth is, no, not a good idea ;)

Strongly seconded. Localized whitespace fixes are OK, because manageable
in the amount of work they generate, but please, not a massive cleanup.
And if we ever do that massive cleanup, I would request that a
pre-requisite is an "update" check on the git server that rejects pushes
of files violating that rule.

On my end of things, I configured my editor to simply highlight
trailing spaces, not strip them.

-- 
Joel


  reply	other threads:[~2014-01-09 15:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19  0:19 Ben Longbons
2014-01-09 14:45 ` Gary Benson
2014-01-09 14:57   ` Phil Muldoon
2014-01-09 15:01     ` Joel Brobecker [this message]
2014-01-09 18:46       ` Dmitry Samersoff
2014-01-10  3:44         ` Samuel Bronson
2014-01-10  4:00           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140109150145.GA3788@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox