From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29954 invoked by alias); 9 Jan 2014 15:01:54 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 29941 invoked by uid 89); 9 Jan 2014 15:01:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 09 Jan 2014 15:01:51 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B31BC116518; Thu, 9 Jan 2014 10:01:49 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id xrMJVlcuc5u4; Thu, 9 Jan 2014 10:01:49 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4D7F81164AC; Thu, 9 Jan 2014 10:01:49 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D220BE047E; Thu, 9 Jan 2014 19:01:45 +0400 (RET) Date: Thu, 09 Jan 2014 15:01:00 -0000 From: Joel Brobecker To: Phil Muldoon Cc: gdb@sourceware.org Subject: Re: Trailing Whitespace Message-ID: <20140109150145.GA3788@adacore.com> References: <20140109144455.GA2972@blade.nx> <20140109145731.GA13720@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140109145731.GA13720@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-01/txt/msg00009.txt.bz2 > Also (and I am not sure if git can get around this somehow) whitespace > cleanups tend to obliterate diffs/patches that were written before the > cleanup took place. This makes merging a massive pain. > > So my 2 pence worth is, no, not a good idea ;) Strongly seconded. Localized whitespace fixes are OK, because manageable in the amount of work they generate, but please, not a massive cleanup. And if we ever do that massive cleanup, I would request that a pre-requisite is an "update" check on the git server that rejects pushes of files violating that rule. On my end of things, I configured my editor to simply highlight trailing spaces, not strip them. -- Joel