From: Gary Benson <gbenson@redhat.com>
To: gdb@sourceware.org
Subject: Re: Trailing Whitespace
Date: Thu, 09 Jan 2014 14:45:00 -0000 [thread overview]
Message-ID: <20140109144455.GA2972@blade.nx> (raw)
In-Reply-To: <CA+XNFZP6JzmOGo=nQDd4kab8RK1zvR4sij_zgS7qdPw7C1W9Vw@mail.gmail.com>
Ben Longbons wrote:
> I have my editor set to trim all trailing whitespace, because
> trailing whitespace is never desirable.
>
> However, since other people have in times past committed code that
> *does* contain trailing whitespace, this creates noise when I'm
> trying to create a patch.
>
> Therefore, I suggest that someone create a commit that removes all
> the trailing whitespace. The pressing need is to apply this to gdb/
> but there is no reason it couldn't be applied to other parts if need
> be.
>
> A commit that does nothing besides change trailing whitespace is
> *not* harmful to the history, because git-blame and other tools can
> all ignore whitespace.
>
> Therefore, the only consideration is whether this will cause
> problems for people with changes that are not yet committed in the
> main repo. The script at the end of this message demonstrates how
> to avoid problems with all 4 of the local branch strategies that I
> know about.
I see nobody replied to this, but it would be pretty nice to have the
repo cleaned in this way.
Does anybody have any reason not to do this?
Thanks,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2014-01-09 14:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 0:19 Ben Longbons
2014-01-09 14:45 ` Gary Benson [this message]
2014-01-09 14:57 ` Phil Muldoon
2014-01-09 15:01 ` Joel Brobecker
2014-01-09 18:46 ` Dmitry Samersoff
2014-01-10 3:44 ` Samuel Bronson
2014-01-10 4:00 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109144455.GA2972@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox