From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17175 invoked by alias); 9 Jan 2014 14:45:03 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 17135 invoked by uid 89); 9 Jan 2014 14:45:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2014 14:45:00 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s09EivBx019847 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 Jan 2014 09:44:58 -0500 Received: from blade.nx (ovpn-116-58.ams2.redhat.com [10.36.116.58]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s09EiuBS023556 for ; Thu, 9 Jan 2014 09:44:57 -0500 Received: by blade.nx (Postfix, from userid 1000) id 179152623A3; Thu, 9 Jan 2014 14:44:56 +0000 (GMT) Date: Thu, 09 Jan 2014 14:45:00 -0000 From: Gary Benson To: gdb@sourceware.org Subject: Re: Trailing Whitespace Message-ID: <20140109144455.GA2972@blade.nx> Mail-Followup-To: gdb@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00007.txt.bz2 Ben Longbons wrote: > I have my editor set to trim all trailing whitespace, because > trailing whitespace is never desirable. > > However, since other people have in times past committed code that > *does* contain trailing whitespace, this creates noise when I'm > trying to create a patch. > > Therefore, I suggest that someone create a commit that removes all > the trailing whitespace. The pressing need is to apply this to gdb/ > but there is no reason it couldn't be applied to other parts if need > be. > > A commit that does nothing besides change trailing whitespace is > *not* harmful to the history, because git-blame and other tools can > all ignore whitespace. > > Therefore, the only consideration is whether this will cause > problems for people with changes that are not yet committed in the > main repo. The script at the end of this message demonstrates how > to avoid problems with all 4 of the local branch strategies that I > know about. I see nobody replied to this, but it would be pretty nice to have the repo cleaned in this way. Does anybody have any reason not to do this? Thanks, Gary -- http://gbenson.net/