Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: drow@failse.org
Cc: gdb@sourceware.org
Subject: Regression
Date: Tue, 10 Feb 2009 15:14:00 -0000	[thread overview]
Message-ID: <200902101514.n1AFEOu1020070@brahms.sibelius.xs4all.nl> (raw)

Hi Daniel,

The following commit breaks the signal command on OpenBSD.  Can you
please revert it for now?

2009-01-20  Daniel Jacobowitz  <dan@codesourcery.com>

        PR gdb/9346
        * infcmd.c (signal_command): Do not specify a resume PC.

Index: infcmd.c
===================================================================
RCS file: /cvs/src/src/gdb/infcmd.c,v
retrieving revision 1.230
retrieving revision 1.229
diff -u -p -r1.230 -r1.229
--- infcmd.c	20 Jan 2009 15:33:13 -0000	1.230
+++ infcmd.c	18 Jan 2009 17:42:16 -0000	1.229
@@ -1145,7 +1145,11 @@ signal_command (char *signum_exp, int fr
     }
 
   clear_proceed_status ();
-  proceed ((CORE_ADDR) -1, oursig, 0);
+  /* "signal 0" should not get stuck if we are stopped at a breakpoint.
+     FIXME: Neither should "signal foo" but when I tried passing
+     (CORE_ADDR)-1 unconditionally I got a testsuite failure which I haven't
+     tried to track down yet.  */
+  proceed (oursig == TARGET_SIGNAL_0 ? (CORE_ADDR) -1 : stop_pc, oursig, 0);
 }
 
 /* Proceed until we reach a different source line with pc greater than


             reply	other threads:[~2009-02-10 15:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-10 15:14 Mark Kettenis [this message]
2009-02-10 15:17 Regression Mark Kettenis
2009-02-10 15:27 ` Regression Daniel Jacobowitz
2009-02-10 15:47   ` Regression Mark Kettenis
2009-02-10 16:06     ` Regression Pedro Alves
2009-02-10 16:18       ` Regression Tristan Gingold
2009-02-10 18:00       ` Regression Pedro Alves
2009-02-10 18:40         ` Regression Mark Kettenis
2009-02-10 19:05           ` Regression Pedro Alves
2009-02-10 19:18             ` Regression Pedro Alves
2009-02-10 19:27               ` Regression Pedro Alves
2009-02-11 15:50                 ` Regression Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902101514.n1AFEOu1020070@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=drow@failse.org \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox