GDB 6.6 branch FROZEN

GDB 6.6 branch FROZEN

[Joel Brobecker]

Hello everyone,

please avoid any checkins on the gdb-6.6 branch, as I'm preparing
the first release candidate...

Thank you!
-- 
Joel

Re: GDB 6.6 branch FROZEN

[H. J. Lu]

On Sat, Dec 02, 2006 at 09:46:13AM -0800, Joel Brobecker wrote:
> Hello everyone,
> 
> please avoid any checkins on the gdb-6.6 branch, as I'm preparing
> the first release candidate...

Any possibility to fix the regression from gdb 6.4, PR tui/2173?
I am enclosing the patch here.


H.J.
----
Index: readline/readline.c
===================================================================
RCS file: /cvs/src/src/readline/readline.c,v
retrieving revision 1.10
diff -u -p -r1.10 readline.c
--- readline/readline.c	5 May 2006 18:26:12 -0000	1.10
+++ readline/readline.c	22 Nov 2006 19:40:17 -0000
@@ -295,6 +295,7 @@ readline (prompt)
      const char *prompt;
 {
   char *value;
+  int in_callback;
 
   /* If we are at EOF return a NULL string. */
   if (rl_pending_input == EOF)
@@ -303,6 +304,13 @@ readline (prompt)
       return ((char *)NULL);
     }
 
+  /* When we call readline, we have to make sure that readline isn't in
+     the callback state. Otherwise, it will get really confused.
+     PR gdb tui/2173.  */
+  in_callback = RL_ISSTATE (RL_STATE_CALLBACK);
+  if (in_callback)
+    RL_UNSETSTATE (RL_STATE_CALLBACK);
+
   rl_set_prompt (prompt);
 
   rl_initialize ();
@@ -321,6 +329,9 @@ readline (prompt)
   rl_clear_signals ();
 #endif
 
+  if (in_callback)
+    RL_SETSTATE (RL_STATE_CALLBACK);
+
   return (value);
 }
 

Re: GDB 6.6 branch FROZEN

[Joel Brobecker]

> Any possibility to fix the regression from gdb 6.4, PR tui/2173?
> I am enclosing the patch here.

I am not opposed, but I don't know readline very well. I'll pass
for this pre-release, but can you send the question on gdb-patches
and ask if the patch is safe enough for the branch? I'll defer
to the judgment of the global maintainers.

Thank you,

> Index: readline/readline.c
> ===================================================================
> RCS file: /cvs/src/src/readline/readline.c,v
> retrieving revision 1.10
> diff -u -p -r1.10 readline.c
> --- readline/readline.c	5 May 2006 18:26:12 -0000	1.10
> +++ readline/readline.c	22 Nov 2006 19:40:17 -0000
> @@ -295,6 +295,7 @@ readline (prompt)
>       const char *prompt;
>  {
>    char *value;
> +  int in_callback;
>  
>    /* If we are at EOF return a NULL string. */
>    if (rl_pending_input == EOF)
> @@ -303,6 +304,13 @@ readline (prompt)
>        return ((char *)NULL);
>      }
>  
> +  /* When we call readline, we have to make sure that readline isn't in
> +     the callback state. Otherwise, it will get really confused.
> +     PR gdb tui/2173.  */
> +  in_callback = RL_ISSTATE (RL_STATE_CALLBACK);
> +  if (in_callback)
> +    RL_UNSETSTATE (RL_STATE_CALLBACK);
> +
>    rl_set_prompt (prompt);
>  
>    rl_initialize ();
> @@ -321,6 +329,9 @@ readline (prompt)
>    rl_clear_signals ();
>  #endif
>  
> +  if (in_callback)
> +    RL_SETSTATE (RL_STATE_CALLBACK);
> +
>    return (value);
>  }
>  

-- 
Joel

Re: GDB 6.6 branch FROZEN

[Joel Brobecker]

> I am not opposed, but I don't know readline very well. I'll pass
> for this pre-release, but can you send the question on gdb-patches
> and ask if the patch is safe enough for the branch? I'll defer
> to the judgment of the global maintainers.

Actually, I was trying to find out who approved the patch, but it looks
like it's not checked in the head either. Let's get it approved for the
head first, and ask whether it's ok for the branch while we're at it.

Thanks,
-- 
Joel

Re: GDB 6.6 branch FROZEN

[H. J. Lu]

On Sat, Dec 02, 2006 at 10:02:59AM -0800, Joel Brobecker wrote:
> > Any possibility to fix the regression from gdb 6.4, PR tui/2173?
> > I am enclosing the patch here.
> 
> I am not opposed, but I don't know readline very well. I'll pass
> for this pre-release, but can you send the question on gdb-patches
> and ask if the patch is safe enough for the branch? I'll defer
> to the judgment of the global maintainers.
> 

Here are some info

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215816
http://sources.redhat.com/ml/gdb-patches/2006-11/msg00327.html

bash-3.1$ gdb gdb
GNU gdb 6.6.50.20061202-cvs
Copyright (C) 2006 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and
you are
welcome to change it and/or distribute copies of it under certain
conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for
details.
This GDB was configured as "x86_64-unknown-linux-gnu"...
Using host libthread_db library "/lib64/libthread_db.so.1".
Setting up the environment for debugging gdb.
Breakpoint 1 at 0x448c00: file /export/gnu/src/gdb/gdb/gdb/utils.c,
line 817.
Breakpoint 2 at 0x47caf0: file
/export/gnu/src/gdb/gdb/gdb/cli/cli-cmds.c, line 200.
(top-gdb) b main
Breakpoint 3 at 0x4414f0: file /export/gnu/src/gdb/gdb/gdb/gdb.c, line
28.
(top-gdb) define foo
Type commands for definition of "foo".
End with a line saying just "end".
>Quit
(top-gdb) command 1
Type commands for when breakpoint 1 is hit, one per line.
End with a line saying just "end".
>define foo
>end
(top-gdb) 

So arrow works and

(gdb) define foo
> <Control-C>

works.


H.J.

Re: GDB 6.6 branch FROZEN

[Joel Brobecker]

> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215816
> http://sources.redhat.com/ml/gdb-patches/2006-11/msg00327.html

Humpf, looks like the fix is not obvious at all. The real gdb-6.6
release is still 2 weeks away. I am still not opposed to porting
any fix to the 6.6 branch, but I'll definitely want the global
maintainers to give their approval (or else a confirmation from
Chet?). In the meantime, I'll document the issue...

-- 
Joel

GDB 6.6 branch UNFROZEN

[Joel Brobecker]

The branch is now open again for checkins.

Thank you,
-- 
Joel