From: Daniel Jacobowitz <drow@false.org>
To: Chet Ramey <chet.ramey@case.edu>
Cc: bug-readline@gnu.org, gdb@sourceware.org, chet@case.edu
Subject: Re: MinGW status for readline
Date: Tue, 11 Apr 2006 14:33:00 -0000 [thread overview]
Message-ID: <20060411135550.GA22588@nevyn.them.org> (raw)
In-Reply-To: <443BB2CA.20200@case.edu>
On Tue, Apr 11, 2006 at 09:44:42AM -0400, Chet Ramey wrote:
> Daniel Jacobowitz wrote:
>
> > 1. Readline 5.1 currently fails to build for MinGW, in tilde.c. The
> > problem is:
> >
> > dirname = glue_prefix_and_suffix (user_entry->pw_dir, filename, user_len);
> >
> > I've just moved the else branch inside the #if defined (HAVE_GETPWENT),
> > from just below. With that change, readline builds. Here's the patch:
>
> Thanks, though that patch introduces a memory leak.
How? Oh, if HAVE_GETPWNAME but not HAVE_GETPWENT? I'm not sure why
you've got a call to endpwent there at all; I thought that only closed
getpwent, not getpwnam, and that path doesn't call getpwent.
> Thanks, I fixed it.
Great, thank you!
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-04-11 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 20:11 Daniel Jacobowitz
2006-04-07 21:53 ` Bob Rossi
2006-04-08 6:31 ` Daniel Jacobowitz
2006-04-11 14:15 ` Chet Ramey
2006-04-11 14:33 ` Daniel Jacobowitz [this message]
2006-04-11 14:40 ` Chet Ramey
2006-04-11 15:12 ` Daniel Jacobowitz
2006-04-11 15:31 ` Chet Ramey
2006-04-12 1:01 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060411135550.GA22588@nevyn.them.org \
--to=drow@false.org \
--cc=bug-readline@gnu.org \
--cc=chet.ramey@case.edu \
--cc=chet@case.edu \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox