From: Chet Ramey <chet.ramey@case.edu>
To: bug-readline@gnu.org, gdb@sourceware.org
Cc: chet@case.edu
Subject: Re: MinGW status for readline
Date: Tue, 11 Apr 2006 15:31:00 -0000 [thread overview]
Message-ID: <443BC59F.7040805@case.edu> (raw)
In-Reply-To: <20060411144053.GA27577@nevyn.them.org>
Daniel Jacobowitz wrote:
> On Tue, Apr 11, 2006 at 10:15:07AM -0400, Chet Ramey wrote:
>> No, you never free username. isolate_tilde_prefix allocates memory
>> whether you have the getpwent family available or not.
>
> It should be? user_entry = 0, so the other branch of the if is taken.
?
`username' is assigned before user_entry is. It really should be freed
outside the if-then block, now that I'm looking at it.
>> (I call endpwent() because its sole usual purpose is to close any open
>> file descriptors on the password database, whatever it is. getpwent
>> and getpwnam usually keep the database open.)
>
> Oh, huh. So much for useful man pages.
The BSD man pages, at least, say
The endpwent() function closes any open files.
Chet
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
( ``Discere est Dolere'' -- chet )
Live Strong. No day but today.
Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/
next prev parent reply other threads:[~2006-04-11 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 20:11 Daniel Jacobowitz
2006-04-07 21:53 ` Bob Rossi
2006-04-08 6:31 ` Daniel Jacobowitz
2006-04-11 14:15 ` Chet Ramey
2006-04-11 14:33 ` Daniel Jacobowitz
2006-04-11 14:40 ` Chet Ramey
2006-04-11 15:12 ` Daniel Jacobowitz
2006-04-11 15:31 ` Chet Ramey [this message]
2006-04-12 1:01 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443BC59F.7040805@case.edu \
--to=chet.ramey@case.edu \
--cc=bug-readline@gnu.org \
--cc=chet@case.edu \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox