From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10585 invoked by alias); 11 Apr 2006 13:55:56 -0000 Received: (qmail 10577 invoked by uid 22791); 11 Apr 2006 13:55:55 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 11 Apr 2006 13:55:53 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FTJLS-0005td-8i; Tue, 11 Apr 2006 09:55:50 -0400 Date: Tue, 11 Apr 2006 14:33:00 -0000 From: Daniel Jacobowitz To: Chet Ramey Cc: bug-readline@gnu.org, gdb@sourceware.org, chet@case.edu Subject: Re: MinGW status for readline Message-ID: <20060411135550.GA22588@nevyn.them.org> Mail-Followup-To: Chet Ramey , bug-readline@gnu.org, gdb@sourceware.org, chet@case.edu References: <20060407200149.GA28248@nevyn.them.org> <443BB2CA.20200@case.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <443BB2CA.20200@case.edu> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00133.txt.bz2 On Tue, Apr 11, 2006 at 09:44:42AM -0400, Chet Ramey wrote: > Daniel Jacobowitz wrote: > > > 1. Readline 5.1 currently fails to build for MinGW, in tilde.c. The > > problem is: > > > > dirname = glue_prefix_and_suffix (user_entry->pw_dir, filename, user_len); > > > > I've just moved the else branch inside the #if defined (HAVE_GETPWENT), > > from just below. With that change, readline builds. Here's the patch: > > Thanks, though that patch introduces a memory leak. How? Oh, if HAVE_GETPWNAME but not HAVE_GETPWENT? I'm not sure why you've got a call to endpwent there at all; I thought that only closed getpwent, not getpwnam, and that path doesn't call getpwent. > Thanks, I fixed it. Great, thank you! -- Daniel Jacobowitz CodeSourcery