From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Bjarke Viksoe <bviksoe@hotmail.com>, gdb@sourceware.org
Subject: Re: MI error msgs and localization
Date: Wed, 15 Feb 2006 03:05:00 -0000 [thread overview]
Message-ID: <20060215030507.GA8700@nevyn.them.org> (raw)
In-Reply-To: <17394.34829.877266.50785@kahikatea.snap.net.nz>
On Wed, Feb 15, 2006 at 02:46:53PM +1300, Nick Roberts wrote:
> That's not quite what I said but it's a better idea as fewer changes need be
> made. Better still might be to use a global variable, perhaps
> mi_error_message in mi-main.c could be used. How about something like the
> patch below (in mi_execute_command) to be used like this:
>
> mi_error_message = xstrprintf ("no-debugging-symbols");
> error(_("No debugging symbols found");
>
> to give:
>
> &"No debugging symbols found\n"
> ^error,msg="no-debugging-symbols"
Please don't. If you need to pass two arguments to error, make a
two-argument version :-)
Passing arguments by globals is bad news.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-02-15 3:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-12 14:54 Bjarke Viksoe
2006-02-12 20:49 ` Nick Roberts
2006-02-13 18:37 ` Bjarke Viksoe
2006-02-13 19:56 ` Eli Zaretskii
2006-02-13 20:01 ` Daniel Jacobowitz
2006-02-14 1:30 ` Nick Roberts
2006-02-14 17:40 ` Bjarke Viksoe
2006-02-14 19:42 ` Eli Zaretskii
2006-02-14 20:59 ` Nick Roberts
2006-02-14 21:05 ` Daniel Jacobowitz
2006-02-14 23:26 ` Nick Roberts
2006-02-14 23:32 ` Daniel Jacobowitz
2006-02-15 1:48 ` Nick Roberts
2006-02-15 3:05 ` Daniel Jacobowitz [this message]
2006-02-15 4:48 ` Nick Roberts
2006-02-15 13:37 ` Daniel Jacobowitz
2006-02-15 21:03 ` Nick Roberts
2006-02-15 21:17 ` Daniel Jacobowitz
2006-02-15 1:55 ` Bob Rossi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060215030507.GA8700@nevyn.them.org \
--to=drow@false.org \
--cc=bviksoe@hotmail.com \
--cc=gdb@sourceware.org \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox