Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: Bjarke Viksoe <bviksoe@hotmail.com>, gdb@sourceware.org
Subject: Re: MI error msgs and localization
Date: Tue, 14 Feb 2006 23:26:00 -0000	[thread overview]
Message-ID: <17394.26332.314215.498261@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20060214210505.GA817@nevyn.them.org>

 > GCC developers spent a lot of time talking about this.  I think the
 > trick to doing this right is actually to do it the way Bjarke
 > suggested: msg= as a free-form, explanatory text, and type= (or code=,
 > or something else) as a documented identifier.  But using numbers for
 > the identifiers is not necessarily a good idea, because keeping track
 > of them is error-prone.  I'd suggest that
 > type="init-option-unrecognized" was a lot more memorable than
 > "code=35".

You wouldn't have to remember them, thay're for use by the front-end, not the
user.  In any case the console log stream gets printed alongside, which should
be self-explanatory.  How would you arrange for the type message to be
printed?  Would you give error a second string argument?  It has over 1200
calls.

 > We have to be careful what error messages get identifiers, though.
 > Please don't anybody go through the source indiscriminately adding
 > them.  Many errors will still be subject to change even if you tack
 > permanent identifiers on them.

All calls to error could be given a dummy argument (0, if numbers are used),
and replaced with a real one only in thoses cases when a need arises.

Nick


  reply	other threads:[~2006-02-14 23:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-12 14:54 Bjarke Viksoe
2006-02-12 20:49 ` Nick Roberts
2006-02-13 18:37   ` Bjarke Viksoe
2006-02-13 19:56     ` Eli Zaretskii
2006-02-13 20:01     ` Daniel Jacobowitz
2006-02-14  1:30     ` Nick Roberts
2006-02-14 17:40       ` Bjarke Viksoe
2006-02-14 19:42         ` Eli Zaretskii
2006-02-14 20:59         ` Nick Roberts
2006-02-14 21:05           ` Daniel Jacobowitz
2006-02-14 23:26             ` Nick Roberts [this message]
2006-02-14 23:32               ` Daniel Jacobowitz
2006-02-15  1:48                 ` Nick Roberts
2006-02-15  3:05                   ` Daniel Jacobowitz
2006-02-15  4:48                     ` Nick Roberts
2006-02-15 13:37                       ` Daniel Jacobowitz
2006-02-15 21:03                         ` Nick Roberts
2006-02-15 21:17                           ` Daniel Jacobowitz
2006-02-15  1:55             ` Bob Rossi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17394.26332.314215.498261@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=bviksoe@hotmail.com \
    --cc=drow@false.org \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox