Re: Adding file to gdb

Re: Adding file to gdb

[Michael Elizabeth Chastain]

Hi Bob,

> Is the gdb-patches@sources.redhat.com mailing list more appropriate for
> this Email?

No, this is fine.

> If I am going to submit a patch that adds a single file to gdb, do I
> need to submit a patch of the Makefile changes also? Or will the
> maintainer automatically fix the Makefile.am and configure code to do
> this?

You have to include the Makefile.in and configure/configure.in changes
as well.  See the big Ingham/Seitz/Zannoni/Cagney patch for an example.

  http://sources.redhat.com/ml/gdb-patches/2003-02/msg00138.html

> Is this all I need to do? Or is there something else I should do 
> before I submit the patch?

I like it when people describe what they did to test their patch.
I'm trying to persuade other people to do this too.  But most people
don't say how they test, so it's okay if you don't.

Did you run the gdb test suite?  On which platforms?

> Also, Should I do the context diff from src/ using 'cvs diff -c' ?

Either src/ or gdb/, we tend to be relaxed about this.

Michael C

Re: Adding file to gdb

[Bob Rossi]

On Sun, Feb 09, 2003 at 04:06:14PM -0600, Michael Elizabeth Chastain wrote:
> Hi Bob,
> 
> Did you run the gdb test suite?  On which platforms?

I have never run the testsuite for gdb before. I did a little research
and discovered I had to install DejaGnu. I then went into 
src/gdb/testsuite and typed 'make check'. 

The results are 
*******************************************************************************
Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using ./config/unix.exp as tool-and-target-specific interface file.
Running ./gdb.arch/altivec-abi.exp ...
Running ./gdb.arch/altivec-regs.exp ...
... more ...
Running ./gdb.base/pointers.exp ...
Running ./gdb.base/printcmds.exp ...
ERROR: (DejaGnu) proc "setup_kfail gdb/538 *-*-*" does not exist.
The error code is NONE
The info on the error is:
close: spawn id exp8 not open
   while executing
"close -i exp8"
   invoked from within
"catch "close -i $spawn_id""

               === gdb Summary ===

# of expected passes    3462
# of unexpected successes  1
# of expected failures     50
# of unsupported tests     1
/home/bob/cvs/gdb/gdb/testsuite/../../gdb/gdb version  2003-02-09-cvs
-nx

make: *** [just-check] Error 1
*******************************************************************************

Is this the expected output? It seems odd that make ends in an error.
Should I run the testsuite differently to run more tests, 
or do they all run be default?

Thanks,
Bobby

Re: Adding file to gdb

[Michael Elizabeth Chastain]

Ah, you need dejagnu 1.4.3 or later.  Gdb uses the new 'kfail'
feature of dejagnu 1.4.3.

There are two ways to get this.  You can download dejagnu from
ftp.gnu.org or a mirror site, build it with the "--prefix" option, and
add the installation directory to your path.  Or, you can "cvs checkout
dejagnu" from sources.redhat.com, which is almost identical to dejagnu
1.4.3.

Dejagnu requires TCL and Expect.  The "dejagnu" module from
sources.redhat.com includes TCL + Expect + Dejagnu, and it also has
Makefile magic to use the dejagnu in the tree to use that dejagnu
instead of the one in your path.

A lot of people who work on gdb just do "cvs checkout gdb+dejagnu".
I run a test bed with the stock FSF version of dejagnu instead of
the sources.redhat.com version.  Either way is good.

Michael C

Adding file to gdb

[Bob Rossi]

Is the gdb-patches@sources.redhat.com mailing list more appropriate for
this Email?

If I am going to submit a patch that adds a single file to gdb, do I
need to submit a patch of the Makefile changes also? Or will the
maintainer automatically fix the Makefile.am and configure code to do
this?

To be explicit, the file I added is src/gdb/mi/mi-cmd-file.c
The Makefile I edited was src/gdb/Makefile

The other files I modified are, 
   src/gdb/mi/ChangeLog     -> Describing change
   src/gdb/mi/gdbmi.texinfo -> Documenting change
   src/gdb/mi/mi-cmds.c     -> Added -file-list-exec-source-file
                            -> displays current line and absolute path
                            -> to file 
   src/gdb/mi/mi-cmds.h      -> adds prototype of new mi function
   
Is this all I need to do? Or is there something else I should do 
before I submit the patch?

Also, Should I do the context diff from src/ using 'cvs diff -c' ?

Thanks for your help,
Bobby