From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14646 invoked by alias); 9 Feb 2003 22:06:15 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 14638 invoked from network); 9 Feb 2003 22:06:15 -0000 Received: from unknown (HELO duracef.shout.net) (204.253.184.12) by 172.16.49.205 with SMTP; 9 Feb 2003 22:06:15 -0000 Received: (from mec@localhost) by duracef.shout.net (8.11.6/8.11.6) id h19M6ES24632; Sun, 9 Feb 2003 16:06:14 -0600 Date: Sun, 09 Feb 2003 22:06:00 -0000 From: Michael Elizabeth Chastain Message-Id: <200302092206.h19M6ES24632@duracef.shout.net> To: bob_rossi@cox.net, gdb@sources.redhat.com Subject: Re: Adding file to gdb X-SW-Source: 2003-02/txt/msg00172.txt.bz2 Hi Bob, > Is the gdb-patches@sources.redhat.com mailing list more appropriate for > this Email? No, this is fine. > If I am going to submit a patch that adds a single file to gdb, do I > need to submit a patch of the Makefile changes also? Or will the > maintainer automatically fix the Makefile.am and configure code to do > this? You have to include the Makefile.in and configure/configure.in changes as well. See the big Ingham/Seitz/Zannoni/Cagney patch for an example. http://sources.redhat.com/ml/gdb-patches/2003-02/msg00138.html > Is this all I need to do? Or is there something else I should do > before I submit the patch? I like it when people describe what they did to test their patch. I'm trying to persuade other people to do this too. But most people don't say how they test, so it's okay if you don't. Did you run the gdb test suite? On which platforms? > Also, Should I do the context diff from src/ using 'cvs diff -c' ? Either src/ or gdb/, we tend to be relaxed about this. Michael C