Re: [remote] Where is S AA p PID currently specified?

[Michael Snyder <msnyder@specifix.com>]

On Tue, 2008-06-10 at 19:44 +0100, Pedro Alves wrote:
> Hi,
> 
> I see this in remote.c:remote_wait, while handling the 'S' and 'T'
> stop reply packets:
> 
[...]
> 	case 'S':		/* Old style status, just signal only.  */
> 	  if (solibs_changed)
> 	    status->kind = TARGET_WAITKIND_LOADED;
> 	  else
> 	    {
> 	      status->kind = TARGET_WAITKIND_STOPPED;
> 	      status->value.sig = (enum target_signal)
> 		(((fromhex (buf[1])) << 4) + (fromhex (buf[2])));
> 	    }
> 
> 	  if (buf[3] == 'p')
> 	    {
> 	      thread_num = strtol ((const char *) &buf[4], NULL, 16);
> 	      record_currthread (thread_num);
> 	    }
> 	  goto got_status;
> 
> 
> Where's that 'p' after S AA specified?  I don't see it in the docs,
> in either S or T stop reply packets description.  Looking through the
> file history, it seemed this had to do with some old Cisco
> extensions that have since been removed, but this bit got left behind.
> 
> Can we remove it ?

OK, you're right -- that 'p' suffix came in between releases 
4.18 and 5.0, and the earliest code has comments mentioning
Cisco kernel threads.

Nuke it!

;-)
Michael