From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-32049-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 23675 invoked by alias); 10 Jun 2008 23:43:47 -0000
Received: (qmail 23667 invoked by uid 22791); 10 Jun 2008 23:43:46 -0000
X-Spam-Check-By: sourceware.org
Received: from bluesmobile.specifix.com (HELO bluesmobile.specifix.com) (216.129.118.140)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Jun 2008 23:43:29 +0000
Received: from [127.0.0.1] (bluesmobile.specifix.com [216.129.118.140]) 	by bluesmobile.specifix.com (Postfix) with ESMTP id D172C3C34A; 	Tue, 10 Jun 2008 16:43:27 -0700 (PDT)
Subject: Re: [remote] Where is S AA p PID currently specified?
From: Michael Snyder <msnyder@specifix.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb@sourceware.org
In-Reply-To: <200806101944.15058.pedro@codesourcery.com>
References: <200806101944.15058.pedro@codesourcery.com>
Content-Type: text/plain
Date: Tue, 10 Jun 2008 23:43:00 -0000
Message-Id: <1213141407.3601.575.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.10.3 (2.10.3-7.fc7)
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2008-06/txt/msg00086.txt.bz2

On Tue, 2008-06-10 at 19:44 +0100, Pedro Alves wrote:
> Hi,
> 
> I see this in remote.c:remote_wait, while handling the 'S' and 'T'
> stop reply packets:
> 
[...]
> 	case 'S':		/* Old style status, just signal only.  */
> 	  if (solibs_changed)
> 	    status->kind = TARGET_WAITKIND_LOADED;
> 	  else
> 	    {
> 	      status->kind = TARGET_WAITKIND_STOPPED;
> 	      status->value.sig = (enum target_signal)
> 		(((fromhex (buf[1])) << 4) + (fromhex (buf[2])));
> 	    }
> 
> 	  if (buf[3] == 'p')
> 	    {
> 	      thread_num = strtol ((const char *) &buf[4], NULL, 16);
> 	      record_currthread (thread_num);
> 	    }
> 	  goto got_status;
> 
> 
> Where's that 'p' after S AA specified?  I don't see it in the docs,
> in either S or T stop reply packets description.  Looking through the
> file history, it seemed this had to do with some old Cisco
> extensions that have since been removed, but this bit got left behind.
> 
> Can we remove it ?

OK, you're right -- that 'p' suffix came in between releases 
4.18 and 5.0, and the earliest code has comments mentioning
Cisco kernel threads.

Nuke it!

;-)
Michael