Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb@sourceware.org
Subject: [remote] Where is S AA p PID currently specified?
Date: Tue, 10 Jun 2008 19:44:00 -0000	[thread overview]
Message-ID: <200806101944.15058.pedro@codesourcery.com> (raw)

Hi,

I see this in remote.c:remote_wait, while handling the 'S' and 'T'
stop reply packets:

      switch (buf[0])
       {
        ...

        case 'T':
          ...

	  /* fall through */
	case 'S':		/* Old style status, just signal only.  */
	  if (solibs_changed)
	    status->kind = TARGET_WAITKIND_LOADED;
	  else
	    {
	      status->kind = TARGET_WAITKIND_STOPPED;
	      status->value.sig = (enum target_signal)
		(((fromhex (buf[1])) << 4) + (fromhex (buf[2])));
	    }

	  if (buf[3] == 'p')
	    {
	      thread_num = strtol ((const char *) &buf[4], NULL, 16);
	      record_currthread (thread_num);
	    }
	  goto got_status;


Where's that 'p' after S AA specified?  I don't see it in the docs,
in either S or T stop reply packets description.  Looking through the
file history, it seemed this had to do with some old Cisco
extensions that have since been removed, but this bit got left behind.

Can we remove it ?

-- 
Pedro Alves


             reply	other threads:[~2008-06-10 19:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-10 19:44 Pedro Alves [this message]
2008-06-10 23:43 ` Michael Snyder
2008-06-10 23:58   ` Pedro Alves
  -- strict thread matches above, loose matches on Subject: below --
2008-06-10 19:42 Pedro Alves
2008-06-10 23:04 ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806101944.15058.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox