strsignal() declaration in lin-lwp.c?

strsignal() declaration in lin-lwp.c?

[Kevin Buettner]

I've just run into a problem in which the definition of strsignal() in
lin-lwp.c conflicts with the definition in <string.h>.  Here's the
declaration in lin-lwp.c:

    extern const char *strsignal (int sig);

And here's what it looks like in <string.h>:

    extern char *strsignal (int __sig) __THROW;

The fact that the lin-lwp.c version has a ``const'' is the problem.

Could we remove the ``const'' from the lin-lwp.c declaration?

It seems that we can't remove the declaration entirely because
the declaration that I'm seeing in the header file won't be used
if __USE_GNU is undefined.

Kevin

Re: strsignal() declaration in lin-lwp.c?

[Daniel Jacobowitz]

On Thu, Dec 05, 2002 at 02:43:32PM -0700, Kevin Buettner wrote:
> I've just run into a problem in which the definition of strsignal() in
> lin-lwp.c conflicts with the definition in <string.h>.  Here's the
> declaration in lin-lwp.c:
> 
>     extern const char *strsignal (int sig);
> 
> And here's what it looks like in <string.h>:
> 
>     extern char *strsignal (int __sig) __THROW;
> 
> The fact that the lin-lwp.c version has a ``const'' is the problem.
> 
> Could we remove the ``const'' from the lin-lwp.c declaration?
> 
> It seems that we can't remove the declaration entirely because
> the declaration that I'm seeing in the header file won't be used
> if __USE_GNU is undefined.

I'd say we could remove the const - or just use -D_GNU_SOURCE...
Glibc 2.3.1 has it without const, and so does 2.2.5.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: strsignal() declaration in lin-lwp.c?

[Mark Kettenis]

Daniel Jacobowitz <drow@mvista.com> writes:

> On Thu, Dec 05, 2002 at 02:43:32PM -0700, Kevin Buettner wrote:
> > I've just run into a problem in which the definition of strsignal() in
> > lin-lwp.c conflicts with the definition in <string.h>.  Here's the
> > declaration in lin-lwp.c:
> > 
> >     extern const char *strsignal (int sig);
> > 
> > And here's what it looks like in <string.h>:
> > 
> >     extern char *strsignal (int __sig) __THROW;
> > 
> > The fact that the lin-lwp.c version has a ``const'' is the problem.
> > 
> > Could we remove the ``const'' from the lin-lwp.c declaration?

I think so.

> > It seems that we can't remove the declaration entirely because
> > the declaration that I'm seeing in the header file won't be used
> > if __USE_GNU is undefined.
> 
> I'd say we could remove the const - or just use -D_GNU_SOURCE...
> Glibc 2.3.1 has it without const, and so does 2.2.5.

Let's remove the const first.  We probably should consider
-D_GNU_SOURCE but that requires some serious testing.

Kevin, consider your patch approved.

Mark