From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-11492-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 7937 invoked by alias); 7 Dec 2002 11:53:52 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 7929 invoked from network); 7 Dec 2002 11:53:49 -0000
Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.250)
  by sources.redhat.com with SMTP; 7 Dec 2002 11:53:49 -0000
Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2])
	by walton.kettenis.dyndns.org (8.12.6/8.12.5) with ESMTP id gB7BrglU000277;
	Sat, 7 Dec 2002 12:53:42 +0100 (CET)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1])
	by elgar.kettenis.dyndns.org (8.12.6/8.12.6) with ESMTP id gB7BrgCC000344;
	Sat, 7 Dec 2002 12:53:42 +0100 (CET)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: (from kettenis@localhost)
	by elgar.kettenis.dyndns.org (8.12.6/8.12.6/Submit) id gB7BrbTs000341;
	Sat, 7 Dec 2002 12:53:37 +0100 (CET)
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb@sources.redhat.com
Subject: Re: strsignal() declaration in lin-lwp.c?
References: <1021205214331.ZM16509@localhost.localdomain> <20021205215815.GA21403@nevyn.them.org>
From: Mark Kettenis <kettenis@chello.nl>
Date: Sat, 07 Dec 2002 03:53:00 -0000
In-Reply-To: Daniel Jacobowitz's message of "Thu, 5 Dec 2002 16:58:15 -0500"
Message-ID: <86el8uoxj2.fsf@elgar.kettenis.dyndns.org>
X-SW-Source: 2002-12/txt/msg00151.txt.bz2

Daniel Jacobowitz <drow@mvista.com> writes:

> On Thu, Dec 05, 2002 at 02:43:32PM -0700, Kevin Buettner wrote:
> > I've just run into a problem in which the definition of strsignal() in
> > lin-lwp.c conflicts with the definition in <string.h>.  Here's the
> > declaration in lin-lwp.c:
> > 
> >     extern const char *strsignal (int sig);
> > 
> > And here's what it looks like in <string.h>:
> > 
> >     extern char *strsignal (int __sig) __THROW;
> > 
> > The fact that the lin-lwp.c version has a ``const'' is the problem.
> > 
> > Could we remove the ``const'' from the lin-lwp.c declaration?

I think so.

> > It seems that we can't remove the declaration entirely because
> > the declaration that I'm seeing in the header file won't be used
> > if __USE_GNU is undefined.
> 
> I'd say we could remove the const - or just use -D_GNU_SOURCE...
> Glibc 2.3.1 has it without const, and so does 2.2.5.

Let's remove the const first.  We probably should consider
-D_GNU_SOURCE but that requires some serious testing.

Kevin, consider your patch approved.

Mark