From: Doug Evans <dje@google.com>
To: gdb-patches@sourceware.org
Cc: ludo@gnu.org, eliz@gnu.org
Subject: [PATCH] value.c (record_latest_value): Fix comment.
Date: Fri, 21 Feb 2014 01:22:00 -0000 [thread overview]
Message-ID: <yjt2eh2x6yzw.fsf@ruffy.mtv.corp.google.com> (raw)
Hi.
This patch fixes a comment that was found to be wrong in this thread:
https://sourceware.org/ml/gdb-patches/2014-02/msg00674.html
I checked as far back as 6.1.1, and it's never returned -1.
[I could go back further, but I don't see the point.]
2014-02-20 Doug Evans <dje@google.com>
* value.c (record_latest_value): Fix comment.
diff --git a/gdb/value.c b/gdb/value.c
index 73ba18e..50b0245 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -1642,9 +1642,7 @@ set_value_component_location (struct value *component,
/* Access to the value history. */
/* Record a new value in the value history.
- Returns the absolute history index of the entry.
- Result of -1 indicates the value was not saved; otherwise it is the
- value history index of this new item. */
+ Returns the absolute history index of the entry. */
int
record_latest_value (struct value *val)
next reply other threads:[~2014-02-21 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 1:22 Doug Evans [this message]
2014-02-21 1:28 ` Doug Evans
2014-02-24 22:02 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yjt2eh2x6yzw.fsf@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox