Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: gdb-patches <gdb-patches@sourceware.org>
Cc: ludo@gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] value.c (record_latest_value): Fix comment.
Date: Mon, 24 Feb 2014 22:02:00 -0000	[thread overview]
Message-ID: <CADPb22QMXE9vOtrq+QkueeEUxiK7EffNG0HdNQ_RZ2eWu5f3mQ@mail.gmail.com> (raw)
In-Reply-To: <21254.43965.134829.97097@ruffy.mtv.corp.google.com>

On Thu, Feb 20, 2014 at 5:28 PM, Doug Evans <dje@google.com> wrote:
> Doug Evans writes:
>  > Hi.
>  >
>  > This patch fixes a comment that was found to be wrong in this thread:
>  >
>  > https://sourceware.org/ml/gdb-patches/2014-02/msg00674.html
>  >
>  > I checked as far back as 6.1.1, and it's never returned -1.
>  > [I could go back further, but I don't see the point.]
>  >
>  > 2014-02-20  Doug Evans  <dje@google.com>
>  >
>  >      * value.c (record_latest_value): Fix comment.
>
> Hmmm, even part of gdb still thinks record_latest_value can return -1.
>
> 2014-02-20  Doug Evans  <dje@google.com>
>
>         * value.c (record_latest_value): Fix comment.
>         * printcmd.c (print_command_1): Remove code to handle -1 return from
>         record_latest_value.

Committed.


      reply	other threads:[~2014-02-24 22:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21  1:22 Doug Evans
2014-02-21  1:28 ` Doug Evans
2014-02-24 22:02   ` Doug Evans [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADPb22QMXE9vOtrq+QkueeEUxiK7EffNG0HdNQ_RZ2eWu5f3mQ@mail.gmail.com \
    --to=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox