From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-110634-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10165 invoked by alias); 24 Feb 2014 22:02:57 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 10156 invoked by uid 89); 24 Feb 2014 22:02:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-vc0-f176.google.com
Received: from mail-vc0-f176.google.com (HELO mail-vc0-f176.google.com) (209.85.220.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 24 Feb 2014 22:02:55 +0000
Received: by mail-vc0-f176.google.com with SMTP id la4so6382087vcb.35        for <gdb-patches@sourceware.org>; Mon, 24 Feb 2014 14:02:53 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=LYE3pRhOmIMwUcW3MNRLTZjyOObaILoX1BLY11CMrSY=;        b=lfC8H4OGGGiOdQD7hOZMGEwkXxNUuX9RcGTkGKXERVz7FCM6ZDjlUV1bF6tsGccPCn         c/1Udga70uFJjImIsDr0x/4ySOX3lytwKhwlUX/xufROnrV22dpP9c4e5gF4IJB0U/Hh         qBRpCXRsGJX4qi5MnYJAvx9s98se3vGlLm/5968sgSoBdSjmwvix3EiCok5SD9U+rqDj         Js5/caVsifC7OROjhW2ctIs25Cs45IS4X2a4pKc4Fe9v63Wm+rc0ig5QwU/bQbeil296         raeL2LGyaELgcsujEGb9OFG9BKh52PfnSCNhjzNsL1QLchFPQICXkCNEp480Ii1gNlew         f5LQ==
X-Gm-Message-State: ALoCoQllMf3MkmYMJS3jMz+dmZrp9SPMFhV6zDzhhbvk6YTFILPGSkCjD3yUPihZkPCxhiMuKLW0nfrME8J/bQfMvOeqHtEFT+oeAsaichh2BIAXpDu0979CvGsM+vQmBwGe/SjJEVj5+68BXEyJBJ+D1pvL7PvuykZ069ip9lRI6+lG3/IFIZ5HTP8kl2e7PE2p/1WLEk8bhh4oT2CZJYQGy6obpfthwg==
MIME-Version: 1.0
X-Received: by 10.220.11.141 with SMTP id t13mr14423802vct.30.1393279373302; Mon, 24 Feb 2014 14:02:53 -0800 (PST)
Received: by 10.52.51.234 with HTTP; Mon, 24 Feb 2014 14:02:53 -0800 (PST)
In-Reply-To: <21254.43965.134829.97097@ruffy.mtv.corp.google.com>
References: <yjt2eh2x6yzw.fsf@ruffy.mtv.corp.google.com>	<21254.43965.134829.97097@ruffy.mtv.corp.google.com>
Date: Mon, 24 Feb 2014 22:02:00 -0000
Message-ID: <CADPb22QMXE9vOtrq+QkueeEUxiK7EffNG0HdNQ_RZ2eWu5f3mQ@mail.gmail.com>
Subject: Re: [PATCH] value.c (record_latest_value): Fix comment.
From: Doug Evans <dje@google.com>
To: gdb-patches <gdb-patches@sourceware.org>
Cc: ludo@gnu.org, Eli Zaretskii <eliz@gnu.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-02/txt/msg00733.txt.bz2

On Thu, Feb 20, 2014 at 5:28 PM, Doug Evans <dje@google.com> wrote:
> Doug Evans writes:
>  > Hi.
>  >
>  > This patch fixes a comment that was found to be wrong in this thread:
>  >
>  > https://sourceware.org/ml/gdb-patches/2014-02/msg00674.html
>  >
>  > I checked as far back as 6.1.1, and it's never returned -1.
>  > [I could go back further, but I don't see the point.]
>  >
>  > 2014-02-20  Doug Evans  <dje@google.com>
>  >
>  >      * value.c (record_latest_value): Fix comment.
>
> Hmmm, even part of gdb still thinks record_latest_value can return -1.
>
> 2014-02-20  Doug Evans  <dje@google.com>
>
>         * value.c (record_latest_value): Fix comment.
>         * printcmd.c (print_command_1): Remove code to handle -1 return from
>         record_latest_value.

Committed.