From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13950 invoked by alias); 21 Feb 2014 01:22:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13936 invoked by uid 89); 21 Feb 2014 01:22:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pb0-f74.google.com Received: from mail-pb0-f74.google.com (HELO mail-pb0-f74.google.com) (209.85.160.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 21 Feb 2014 01:22:31 +0000 Received: by mail-pb0-f74.google.com with SMTP id jt11so436536pbb.1 for ; Thu, 20 Feb 2014 17:22:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:cc:date:message-id:mime-version :content-type; bh=v0r1fU3SU7C9n7NXr4d+JOKk1jsobzeN+8tBTa68eGE=; b=UurTS2zdaUgK2zBpFdKCEemAVBZAXN4vn/pXSd59f0lfacbeV/NHMsfVRxg/s4E1yz Yo1CmP0parM9wBEqYKBu/ZxeJiZO4x8LN72aOLloIbhJqSJQJ2pRFoSObmJQxjlT52ty H0oMTWlKa82sKByAePce/ncr2vYMUqBlo9u3zxG3Oh0UW50DqCjRFH9Ev7K7nNL7OQ9p S9cmjz3O8t+qSyuS00LUQ0sp/FESo9sBzDoVN6dJPAE4/ZSg7vYrQ7s6OXxryZlWda+x viV7CFHcCjxveimIfjc/mcV0yZ7Ly6+Vsyuv+37IX7s4JxHCzYfM/So+o5Px62T6f3WW BFZw== X-Gm-Message-State: ALoCoQkdzd/jIt38VHXngrrlJ3qv354RSOrtnvZHwpYD6CiE57irqRgTNnudU4qd1IbRVpfcqPSY1PF2J8oQ5C/VqjF2fItCMF316wmn1EkNmnw0t/pzmd8PjDQkVkBztQ1owqTHVOJ4mVbXl3vkzYMjKtTPWM2Rn+6DRSWcIactxQsSVjQPnX+cWBcK3uIrgfZRGCQdeAnQ23xfW7k5cClrc6Sg1eeLCg== X-Received: by 10.66.240.4 with SMTP id vw4mr2204627pac.10.1392945748430; Thu, 20 Feb 2014 17:22:28 -0800 (PST) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id o30si426692yhn.1.2014.02.20.17.22.28 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Feb 2014 17:22:28 -0800 (PST) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 9D4B75A4202; Thu, 20 Feb 2014 17:22:27 -0800 (PST) From: Doug Evans To: gdb-patches@sourceware.org Subject: [PATCH] value.c (record_latest_value): Fix comment. cc: ludo@gnu.org, eliz@gnu.org Date: Fri, 21 Feb 2014 01:22:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00676.txt.bz2 Hi. This patch fixes a comment that was found to be wrong in this thread: https://sourceware.org/ml/gdb-patches/2014-02/msg00674.html I checked as far back as 6.1.1, and it's never returned -1. [I could go back further, but I don't see the point.] 2014-02-20 Doug Evans * value.c (record_latest_value): Fix comment. diff --git a/gdb/value.c b/gdb/value.c index 73ba18e..50b0245 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -1642,9 +1642,7 @@ set_value_component_location (struct value *component, /* Access to the value history. */ /* Record a new value in the value history. - Returns the absolute history index of the entry. - Result of -1 indicates the value was not saved; otherwise it is the - value history index of this new item. */ + Returns the absolute history index of the entry. */ int record_latest_value (struct value *val)