* [patch] Fix gdb.dwarf2/implptr-optimized-out.S
@ 2012-12-13 20:34 Doug Evans
2012-12-13 21:31 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Doug Evans @ 2012-12-13 20:34 UTC (permalink / raw)
To: gdb-patches
Hi.
The DIE offset parameter to DW_OP_GNU_implicit_pointer is section-relative.
[Only noticeable if you happen to end up with some DIEs being put
in front of the DIE for the testcase.]
I will commit this in a few days if there are no objections.
2012-12-13 Doug Evans <dje@google.com>
* gdb.dwarf2/implptr-optimized-out.S: DIE offset for
DW_OP_GNU_implicit_pointer is section-relative.
Index: gdb.dwarf2/implptr-optimized-out.S
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.dwarf2/implptr-optimized-out.S,v
retrieving revision 1.3
diff -u -p -r1.3 implptr-optimized-out.S
--- gdb.dwarf2/implptr-optimized-out.S 15 Mar 2012 09:08:10 -0000 1.3
+++ gdb.dwarf2/implptr-optimized-out.S 13 Dec 2012 20:31:41 -0000
@@ -66,7 +66,7 @@ d:
.byte 2f - 1f /* DW_AT_location: DW_FORM_block1 */
1:
.byte 0xf2 /* DW_OP_GNU_implicit_pointer */
- .4byte .Lvar_out - d /* referenced DIE */
+ .4byte .Lvar_out /* referenced DIE, section-relative! */
.sleb128 0 /* offset */
2:
.4byte .Ltype_structptr - d /* DW_AT_type */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] Fix gdb.dwarf2/implptr-optimized-out.S
2012-12-13 20:34 [patch] Fix gdb.dwarf2/implptr-optimized-out.S Doug Evans
@ 2012-12-13 21:31 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2012-12-13 21:31 UTC (permalink / raw)
To: Doug Evans; +Cc: gdb-patches
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> 2012-12-13 Doug Evans <dje@google.com>
Doug> * gdb.dwarf2/implptr-optimized-out.S: DIE offset for
Doug> DW_OP_GNU_implicit_pointer is section-relative.
Looks good to me.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-13 21:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-13 20:34 [patch] Fix gdb.dwarf2/implptr-optimized-out.S Doug Evans
2012-12-13 21:31 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox