Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: gdb-patches@sourceware.org
Subject: [patch] Fix gdb.dwarf2/implptr-optimized-out.S
Date: Thu, 13 Dec 2012 20:34:00 -0000	[thread overview]
Message-ID: <yjt26245bsim.fsf@ruffy2.mtv.corp.google.com> (raw)

Hi.

The DIE offset parameter to DW_OP_GNU_implicit_pointer is section-relative.
[Only noticeable if you happen to end up with some DIEs being put
in front of the DIE for the testcase.]

I will commit this in a few days if there are no objections.

2012-12-13  Doug Evans  <dje@google.com>

	* gdb.dwarf2/implptr-optimized-out.S: DIE offset for
	DW_OP_GNU_implicit_pointer is section-relative.

Index: gdb.dwarf2/implptr-optimized-out.S
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.dwarf2/implptr-optimized-out.S,v
retrieving revision 1.3
diff -u -p -r1.3 implptr-optimized-out.S
--- gdb.dwarf2/implptr-optimized-out.S	15 Mar 2012 09:08:10 -0000	1.3
+++ gdb.dwarf2/implptr-optimized-out.S	13 Dec 2012 20:31:41 -0000
@@ -66,7 +66,7 @@ d:
 	.byte	2f - 1f	/* DW_AT_location: DW_FORM_block1 */
 1:
 	.byte	0xf2	/* DW_OP_GNU_implicit_pointer */
-	.4byte	.Lvar_out - d	/* referenced DIE */
+	.4byte	.Lvar_out	/* referenced DIE, section-relative! */
 	.sleb128	0	/* offset */
 2:
 	.4byte	.Ltype_structptr - d	/* DW_AT_type */


             reply	other threads:[~2012-12-13 20:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-13 20:34 Doug Evans [this message]
2012-12-13 21:31 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yjt26245bsim.fsf@ruffy2.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox