From: David Carlton <carlton@kealia.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [rfa] partial fix for PR gdb/1245
Date: Mon, 30 Jun 2003 16:25:00 -0000 [thread overview]
Message-ID: <yf2of0fjzxa.fsf@hawaii.kealia.com> (raw)
In-Reply-To: <20030629210642.GA11680@nevyn.them.org> (Daniel Jacobowitz's message of "Sun, 29 Jun 2003 17:06:42 -0400")
On Sun, 29 Jun 2003 17:06:42 -0400, Daniel Jacobowitz <drow@mvista.com> said:
> Yes, this is OK as a bandaid. As I explained in the PR, we can
> correctly handle this, but not asserting is good enough for the
> moment.
Great, thanks. Though I just sent a reply to the PR saying that I
disagree with you about what fix is correct, but never mind that; it's
really not a high priority issue once this patch goes in, I think.
>> case ')':
>> + if (permissive)
>> + {
>> + return index;
>> + }
> Please drop the useless pair of braces.
I guess I did that to balance the else clause, but I'm happy to do it
your way.
Committed on mainline and branch.
David Carlton
carlton@kealia.com
prev parent reply other threads:[~2003-06-30 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-26 1:04 David Carlton
2003-06-29 21:06 ` Daniel Jacobowitz
2003-06-29 21:54 ` Andrew Cagney
2003-06-30 16:25 ` David Carlton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yf2of0fjzxa.fsf@hawaii.kealia.com \
--to=carlton@kealia.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox