From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23566 invoked by alias); 30 Jun 2003 16:25:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23559 invoked from network); 30 Jun 2003 16:25:06 -0000 Received: from unknown (HELO hawaii.kealia.com) (216.101.126.244) by sources.redhat.com with SMTP; 30 Jun 2003 16:25:06 -0000 Received: by hawaii.kealia.com (Postfix, from userid 2049) id 6CEC8BFDF; Mon, 30 Jun 2003 09:25:05 -0700 (PDT) To: gdb-patches@sources.redhat.com Subject: Re: [rfa] partial fix for PR gdb/1245 References: <20030629210642.GA11680@nevyn.them.org> From: David Carlton Date: Mon, 30 Jun 2003 16:25:00 -0000 In-Reply-To: <20030629210642.GA11680@nevyn.them.org> (Daniel Jacobowitz's message of "Sun, 29 Jun 2003 17:06:42 -0400") Message-ID: User-Agent: Gnus/5.1002 (Gnus v5.10.2) XEmacs/21.4 (Rational FORTRAN, linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-06/txt/msg00880.txt.bz2 On Sun, 29 Jun 2003 17:06:42 -0400, Daniel Jacobowitz said: > Yes, this is OK as a bandaid. As I explained in the PR, we can > correctly handle this, but not asserting is good enough for the > moment. Great, thanks. Though I just sent a reply to the PR saying that I disagree with you about what fix is correct, but never mind that; it's really not a high priority issue once this patch goes in, I think. >> case ')': >> + if (permissive) >> + { >> + return index; >> + } > Please drop the useless pair of braces. I guess I did that to balance the else clause, but I'm happy to do it your way. Committed on mainline and branch. David Carlton carlton@kealia.com