From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: David Carlton <carlton@kealia.com>, gdb-patches@sources.redhat.com
Subject: Re: [rfa] partial fix for PR gdb/1245
Date: Sun, 29 Jun 2003 21:54:00 -0000 [thread overview]
Message-ID: <3EFF596E.8070007@redhat.com> (raw)
In-Reply-To: <20030629210642.GA11680@nevyn.them.org>
> case ')':
>> + if (permissive)
>> + {
>> + return index;
>> + }
>
>
> Please drop the useless pair of braces.
BTW, there are advantages and disasvantages to constantly adding and
deleting extra brances. If they are included, follow-on diffs such as:
if (permissive)
{
+ process_index (&index);
return index;
}
read much easier :-)
It'ss a gnu coding standard loose loose situtation :-)
Andrew
next prev parent reply other threads:[~2003-06-29 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-26 1:04 David Carlton
2003-06-29 21:06 ` Daniel Jacobowitz
2003-06-29 21:54 ` Andrew Cagney [this message]
2003-06-30 16:25 ` David Carlton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EFF596E.8070007@redhat.com \
--to=ac131313@redhat.com \
--cc=carlton@kealia.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox