From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-25632-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 24583 invoked by alias); 29 Jun 2003 21:54:39 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 24557 invoked from network); 29 Jun 2003 21:54:38 -0000
Received: from unknown (HELO localhost.redhat.com) (24.157.166.107)
  by sources.redhat.com with SMTP; 29 Jun 2003 21:54:38 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id A19F62B6A; Sun, 29 Jun 2003 17:26:06 -0400 (EDT)
Message-ID: <3EFF596E.8070007@redhat.com>
Date: Sun, 29 Jun 2003 21:54:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Daniel Jacobowitz <drow@mvista.com>
Cc: David Carlton <carlton@kealia.com>,
	gdb-patches@sources.redhat.com
Subject: Re: [rfa] partial fix for PR gdb/1245
References: <m3y8zp3cpu.fsf@coconut.kealia.com> <20030629210642.GA11680@nevyn.them.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-06/txt/msg00876.txt.bz2

>  	case ')':
>> +	  if (permissive)
>> +	    {
>> +	      return index;
>> +	    }
> 
> 
> Please drop the useless pair of braces.

BTW, there are advantages and disasvantages to constantly adding and 
deleting extra brances.  If they are included, follow-on diffs such as:

	if (permissive)
	  {
+	    process_index (&index);
	    return index;
	  }

read much easier :-)

It'ss a gnu coding standard loose loose situtation :-)

Andrew