[PATCH] xfail gdb.base/break-on-linker-gcd-function.exp with Solaris ld [PR34534]

[PATCH] xfail gdb.base/break-on-linker-gcd-function.exp with Solaris ld [PR34534]

[Rainer Orth]

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

As detailed in PR testsuite/34534, a test FAILs on Solaris when using
the native ld:

FAIL: gdb.base/break-on-linker-gcd-function.exp: break on line in garbage collected function
FAIL: gdb.base/break-on-linker-gcd-function.exp: readnow: break on line in garbage collected function

Even though ld supports --gc-sections as an alias for the native -z
discard-unused=sections, this doesn't work in this particular case.
While the issue is under investigation, this patch xfail's the test when
Solaris ld is in use.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34534

Ok for trunk?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: sol2-break-on-linker-gcd-function-xfail.patch --]
[-- Type: text/x-patch, Size: 863 bytes --]

# HG changeset patch
# Parent  8bd5b9b86ee7cd342e93a2b49bc59430fc65aa40
xfail gdb.base/break-on-linker-gcd-function.exp with Solaris ld [PR34534]

diff --git a/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp b/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp
--- a/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp
+++ b/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp
@@ -42,6 +42,13 @@ proc set_breakpoint_on_gcd_function {} {
 
     set lineno [gdb_get_line_number "gdb break here"]
     gdb_test "set breakpoint pending on"
+
+    # PR 34534
+    set compiler [find_g++]
+    set res [catch {exec $compiler -Wl,--version} output]
+    if [regexp "Solaris Link Editors" $output] {
+	setup_xfail "*-*-solaris2*"
+    }
     gdb_test "b $lineno" \
 	[multi_line \
 	     "^No compiled code for line $lineno in the current file\\." \

Re: [PATCH] xfail gdb.base/break-on-linker-gcd-function.exp with Solaris ld [PR34534]

[Tom Tromey]

>>>>> "Rainer" == Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:

Rainer> Even though ld supports --gc-sections as an alias for the native -z
Rainer> discard-unused=sections, this doesn't work in this particular case.
Rainer> While the issue is under investigation, this patch xfail's the test when
Rainer> Solaris ld is in use.

Rainer> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34534

Rainer> Ok for trunk?

A few tiny nits, ok with these fixed.
Approved-By: Tom Tromey <tom@tromey.com>

Rainer> +    # PR 34534

Write 'PR testsuite/34534'.  This is the usual format and works
automatically with Emacs due to gdb/.dir-locals.el.

Rainer> +    if [regexp "Solaris Link Editors" $output] {

Nowadays I think we brace if expressions, so "if {[...]} "

thanks,
Tom

Re: [PATCH] xfail gdb.base/break-on-linker-gcd-function.exp with Solaris ld [PR34534]

[Rainer Orth]

Hi Tom,

>>>>>> "Rainer" == Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
>
> Rainer> Even though ld supports --gc-sections as an alias for the native -z
> Rainer> discard-unused=sections, this doesn't work in this particular case.
> Rainer> While the issue is under investigation, this patch xfail's the test when
> Rainer> Solaris ld is in use.
>
> Rainer> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34534
>
> Rainer> Ok for trunk?
>
> A few tiny nits, ok with these fixed.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Rainer> +    # PR 34534
>
> Write 'PR testsuite/34534'.  This is the usual format and works
> automatically with Emacs due to gdb/.dir-locals.el.

fine with me: I've seen both forms used and wasn't sure which one is
preferred these days.  The full form certainly conveys more information.

> Rainer> +    if [regexp "Solaris Link Editors" $output] {
>
> Nowadays I think we brace if expressions, so "if {[...]} "

Will do, although it's not necessary.

Thanks.
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University