Re: [PATCH] xfail gdb.base/break-on-linker-gcd-function.exp with Solaris ld [PR34534]

[Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>]

Hi Tom,

>>>>>> "Rainer" == Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
>
> Rainer> Even though ld supports --gc-sections as an alias for the native -z
> Rainer> discard-unused=sections, this doesn't work in this particular case.
> Rainer> While the issue is under investigation, this patch xfail's the test when
> Rainer> Solaris ld is in use.
>
> Rainer> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34534
>
> Rainer> Ok for trunk?
>
> A few tiny nits, ok with these fixed.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Rainer> +    # PR 34534
>
> Write 'PR testsuite/34534'.  This is the usual format and works
> automatically with Emacs due to gdb/.dir-locals.el.

fine with me: I've seen both forms used and wasn't sure which one is
preferred these days.  The full form certainly conveys more information.

> Rainer> +    if [regexp "Solaris Link Editors" $output] {
>
> Nowadays I think we brace if expressions, so "if {[...]} "

Will do, although it's not necessary.

Thanks.
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University