From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Provide pid_to_exec_file on Solaris (PR tdep/17903)
Date: Wed, 19 Sep 2018 17:47:00 -0000 [thread overview]
Message-ID: <yddk1nhgz14.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <87bm8tr19q.fsf@tromey.com> (Tom Tromey's message of "Wed, 19 Sep 2018 08:48:49 -0600")
Hi Tom,
> Rainer> + scoped_fd fd (open (name, O_RDONLY));
>
> You may wish to use gdb_open_cloexec.
I'll give it a whirl and change the patch accordingly before committing
if it works out.
> procfs.c is one of the cloexec holdouts, because I could never compile it.
> But I guess once the buildbot is up I can do it :)
Certainly: my proposed buildbot patch adds them to the try_ssh scheduler
to allow just that. In the meantime, you may well send procfs patches
my way if you like ;-)
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2018-09-19 17:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 14:19 Rainer Orth
2018-09-19 14:36 ` Joel Brobecker
2018-09-19 17:44 ` Rainer Orth
2018-09-19 18:06 ` Joel Brobecker
2018-09-19 14:49 ` Tom Tromey
2018-09-19 14:53 ` Simon Marchi
2018-09-19 17:50 ` Rainer Orth
2018-09-19 17:47 ` Rainer Orth [this message]
2018-09-20 9:27 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddk1nhgz14.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox