From: Tom Tromey <tom@tromey.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Provide pid_to_exec_file on Solaris (PR tdep/17903)
Date: Wed, 19 Sep 2018 14:49:00 -0000 [thread overview]
Message-ID: <87bm8tr19q.fsf@tromey.com> (raw)
In-Reply-To: <ydd4lelh8q2.fsf@CeBiTec.Uni-Bielefeld.DE> (Rainer Orth's message of "Wed, 19 Sep 2018 16:17:57 +0200")
>>>>> "Rainer" == Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
Rainer> Tested on amd64-pc-solaris2.10 and amd64-pc-solaris2.11, ok for master?
Thank you for doing this.
Rainer> + char *pid_to_exec_file (int pid) override;
Boy this is a bad API!
Not your problem but I'll make a note on my to-do list to change it to
return a std::string or something like that.
Rainer> + scoped_fd fd (open (name, O_RDONLY));
You may wish to use gdb_open_cloexec.
procfs.c is one of the cloexec holdouts, because I could never compile it.
But I guess once the buildbot is up I can do it :)
Tom
next prev parent reply other threads:[~2018-09-19 14:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 14:19 Rainer Orth
2018-09-19 14:36 ` Joel Brobecker
2018-09-19 17:44 ` Rainer Orth
2018-09-19 18:06 ` Joel Brobecker
2018-09-19 14:49 ` Tom Tromey [this message]
2018-09-19 14:53 ` Simon Marchi
2018-09-19 17:50 ` Rainer Orth
2018-09-19 17:47 ` Rainer Orth
2018-09-20 9:27 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm8tr19q.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox