From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102662 invoked by alias); 19 Sep 2018 17:47:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102647 invoked by uid 89); 19 Sep 2018 17:47:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=wish X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Sep 2018 17:47:24 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 179AA8F6; Wed, 19 Sep 2018 19:47:22 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4AVMHpYmV5KB; Wed, 19 Sep 2018 19:47:20 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p54ACFE4B.dip0.t-ipconnect.de [84.172.254.75]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 8C06E8F5; Wed, 19 Sep 2018 19:47:20 +0200 (CEST) From: Rainer Orth To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Provide pid_to_exec_file on Solaris (PR tdep/17903) References: <87bm8tr19q.fsf@tromey.com> Date: Wed, 19 Sep 2018 17:47:00 -0000 In-Reply-To: <87bm8tr19q.fsf@tromey.com> (Tom Tromey's message of "Wed, 19 Sep 2018 08:48:49 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00704.txt.bz2 Hi Tom, > Rainer> + scoped_fd fd (open (name, O_RDONLY)); > > You may wish to use gdb_open_cloexec. I'll give it a whirl and change the patch accordingly before committing if it works out. > procfs.c is one of the cloexec holdouts, because I could never compile it. > But I guess once the buildbot is up I can do it :) Certainly: my proposed buildbot patch adds them to the try_ssh scheduler to allow just that. In the meantime, you may well send procfs patches my way if you like ;-) Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University