From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Eli Zaretskii <eliz@gnu.org>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Subject: Re: Fix tui compilation with Solaris libcurses (PR tui/21482)
Date: Fri, 19 May 2017 13:26:00 -0000 [thread overview]
Message-ID: <yddefvlx9jk.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <83h90h2dbu.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 19 May 2017 16:20:05 +0300")
Hi Eli,
>> I've checked in the cast part now. Here's the NOMACROS part for
>> gdb_curses.h. Tested as before on sparcv9-sun-solaris2.10 (curses) and
>> amd64-pc-solaris2.12 (ncurses). Ok too?
>
> I think this should be guarded by some OS-specific macro, so as not to
> affect other platforms, where the original problem doesn't exist. (I
> see 6 instances of these macros being tested in my ncurses headers,
> and I'm not on Solaris.) Who knows what new problems this could cause?
that's what I had done initially (via configure.ac for solaris2.* only),
but Pedro suggested to do it unconditionally since some other targets
(AIX notably) seem to be having the same problem.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2017-05-19 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 8:56 Rainer Orth
2017-05-18 13:19 ` Pedro Alves
2017-05-18 13:36 ` Rainer Orth
2017-05-19 12:50 ` Rainer Orth
2017-05-19 12:52 ` Pedro Alves
2017-05-19 13:20 ` Eli Zaretskii
2017-05-19 13:26 ` Rainer Orth [this message]
2017-05-19 13:43 ` Pedro Alves
2017-05-19 13:39 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddefvlx9jk.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox