From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10906 invoked by alias); 19 May 2017 13:26:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10893 invoked by uid 89); 19 May 2017 13:26:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 May 2017 13:26:08 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id AD913FFC; Fri, 19 May 2017 15:26:09 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id s24ZzepXQ73z; Fri, 19 May 2017 15:26:08 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 5B2E1FFB; Fri, 19 May 2017 15:26:08 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id v4JDQ7Nc027840; Fri, 19 May 2017 15:26:07 +0200 (MEST) From: Rainer Orth To: Eli Zaretskii Cc: palves@redhat.com, gdb-patches@sourceware.org Subject: Re: Fix tui compilation with Solaris libcurses (PR tui/21482) References: <32521e83-00b5-e2a8-faff-03b5407cfc67@redhat.com> <83h90h2dbu.fsf@gnu.org> Date: Fri, 19 May 2017 13:26:00 -0000 In-Reply-To: <83h90h2dbu.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 19 May 2017 16:20:05 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-05/txt/msg00443.txt.bz2 Hi Eli, >> I've checked in the cast part now. Here's the NOMACROS part for >> gdb_curses.h. Tested as before on sparcv9-sun-solaris2.10 (curses) and >> amd64-pc-solaris2.12 (ncurses). Ok too? > > I think this should be guarded by some OS-specific macro, so as not to > affect other platforms, where the original problem doesn't exist. (I > see 6 instances of these macros being tested in my ncurses headers, > and I'm not on Solaris.) Who knows what new problems this could cause? that's what I had done initially (via configure.ac for solaris2.* only), but Pedro suggested to do it unconditionally since some other targets (AIX notably) seem to be having the same problem. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University