Re: Fix tui compilation with Solaris libcurses (PR tui/21482)

[Pedro Alves <palves@redhat.com>]

On 05/19/2017 01:50 PM, Rainer Orth wrote:
> Hi Pedro,
> 
>>>> Ok for mainline and 8.0 branch?
>>>
>>> The cast bits are OK.  I'd like to hear your opinion on
>>> moving the NOMACROS define to gdb_curses.h, before including
>>> <curses.h>.
>>
>> The move makes sense to me: I just wasn't aware of that file.  I'll
>> prepare a separate patch.
> 
> I've checked in the cast part now.  Here's the NOMACROS part for
> gdb_curses.h.  Tested as before on sparcv9-sun-solaris2.10 (curses) and
> amd64-pc-solaris2.12 (ncurses).  Ok too?

OK.

> 
> Interestingly, with that patch the previous link failure on Solaris
> 11/12 (missing wattr_on/wattr_off) is gone, too.  This seems to happen
> because <ncurses/ncurses.h> no longer defines
> 
> /usr/include/ncurses/ncurses.h:#define wattron(win,at)          wattr_on(win, NCURSES_CAST(attr_t, at), NULL)
> /usr/include/ncurses/ncurses.h:#define attr_on(a,o)             wattr_on(stdscr,a,o)
> 
> and the references to wattron can be satisfied from libcurses just as
> from libncurses.

Eh, great.

Thanks,
Pedro Alves