From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9007 invoked by alias); 19 May 2017 12:52:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8988 invoked by uid 89); 19 May 2017 12:52:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=ao, hear X-HELO: mail-wr0-f179.google.com Received: from mail-wr0-f179.google.com (HELO mail-wr0-f179.google.com) (209.85.128.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 May 2017 12:52:52 +0000 Received: by mail-wr0-f179.google.com with SMTP id l50so16885794wrc.3 for ; Fri, 19 May 2017 05:52:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=B1GwQIfzXGF2pQhJLAP4YZWemsDDC5heIB15/2raQU8=; b=mfDxvgHHkD62pgHFJ5s+K3waumvoa+VJcZf5Ki7qCxit7pAFJhKr+Htm/+HvkUaYRv na6WzBFt1NIxLqfDUGkhit+cDU7xBRQduEIHqfm2dX6ebDfUFQjRoJ0ryPY7PwJEWzx3 MRa5UD1GXNDLUBNjHxNju437BIR8zhDHyfsdIUZ7p3BnD606RfJDiplyUn7KDOin+ydw 4pXkeHPj2++7sTLOVH9uV2cx3Xu4H1AzPCA1THYmamNc3zcTkptsLkdrJVYHIJPGRk0F qeRPLIPJQ8eRL4Cw+hQlvrtQlbG7UBv2+JkcMWx0/xKa2Rym+DfCYG+SisJ5cuNEZyDq fu8Q== X-Gm-Message-State: AODbwcAYEBelGvv7Da3SiaEdzRlflUHN4eWGzBHkMY1FQd9gFLI2X5Yg kqIzTO79Kd2kadSy X-Received: by 10.223.161.198 with SMTP id v6mr2935612wrv.135.1495198373861; Fri, 19 May 2017 05:52:53 -0700 (PDT) Received: from [192.168.0.102] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id v7sm4315280wrb.68.2017.05.19.05.52.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 May 2017 05:52:53 -0700 (PDT) Subject: Re: Fix tui compilation with Solaris libcurses (PR tui/21482) To: Rainer Orth References: <32521e83-00b5-e2a8-faff-03b5407cfc67@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <598bc861-fcab-2e34-2e79-9cba417bae15@redhat.com> Date: Fri, 19 May 2017 12:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00441.txt.bz2 On 05/19/2017 01:50 PM, Rainer Orth wrote: > Hi Pedro, > >>>> Ok for mainline and 8.0 branch? >>> >>> The cast bits are OK. I'd like to hear your opinion on >>> moving the NOMACROS define to gdb_curses.h, before including >>> . >> >> The move makes sense to me: I just wasn't aware of that file. I'll >> prepare a separate patch. > > I've checked in the cast part now. Here's the NOMACROS part for > gdb_curses.h. Tested as before on sparcv9-sun-solaris2.10 (curses) and > amd64-pc-solaris2.12 (ncurses). Ok too? OK. > > Interestingly, with that patch the previous link failure on Solaris > 11/12 (missing wattr_on/wattr_off) is gone, too. This seems to happen > because no longer defines > > /usr/include/ncurses/ncurses.h:#define wattron(win,at) wattr_on(win, NCURSES_CAST(attr_t, at), NULL) > /usr/include/ncurses/ncurses.h:#define attr_on(a,o) wattr_on(stdscr,a,o) > > and the references to wattron can be satisfied from libcurses just as > from libncurses. Eh, great. Thanks, Pedro Alves