From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: libor.bukata@oracle.com
Cc: gdb-patches@sourceware.org
Subject: Re: Fix a crash in compile_to_object function
Date: Tue, 10 Sep 2019 09:18:00 -0000 [thread overview]
Message-ID: <ydda7bcqzy2.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <2e87a0b1-c3eb-300f-cdf3-1cf3c2963c2b@oracle.com> (libor bukata's message of "Mon, 9 Sep 2019 10:55:37 +0200")
Hi Libor,
> I noticed it from the testsuite results (crash dump generated) for gdb
> 8.3. Although it is not implemented for Solaris, it should not crash, which
> is the reason why I sent a patch that resolves a nullptr dereference. The
> patched gdb prints an error message (instead of crashing) and the user can
> continue with debugging. I agree with you that there many more pressing
> issues that needs to be resolved first.
that explains why I'm not seeing this in my gdb builds: I use a
32-bit-default gcc 9.1 to build a 64-bit gdb, so there's no matching
libcc1.so around and the affected tests are UNTESTED. Fully agreed that
there should be no crashes even for unsupported features, of course.
I'll leave the actual review to the responsible maintainers.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
prev parent reply other threads:[~2019-09-10 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 13:37 libor.bukata
2019-09-06 16:42 ` Keith Seitz
2019-09-06 17:11 ` libor.bukata
2019-09-09 17:56 ` Tom Tromey
2019-09-09 8:07 ` Rainer Orth
2019-09-09 8:57 ` libor.bukata
2019-09-10 9:18 ` Rainer Orth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ydda7bcqzy2.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gdb-patches@sourceware.org \
--cc=libor.bukata@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox