Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: libor.bukata@oracle.com
To: gdb-patches@sourceware.org
Subject: Fix a crash in compile_to_object function
Date: Fri, 06 Sep 2019 13:37:00 -0000	[thread overview]
Message-ID: <3ad99625-43ff-a450-6e50-d83242224443@oracle.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

On non-Linux platforms, gdb crashes when compile command is issued
because of the null pointer in struct osabi_names gdb_osab. The attached
patch adds a check to avoid this crash and adds osabi name for Solaris.
However, there is probably more work required to enable compile feature
on Solaris (e.g., solaris_infcall_munmap) and other platforms.

Thanks,
Libor

[-- Attachment #2: 001-fix-null-ptr.patch --]
[-- Type: text/x-patch, Size: 1034 bytes --]

The patch fixes the crash on non-Linux platforms when
os_rx is a null pointer and converted to C++ std::string.

--- gdb-8.3/gdb/osabi.c	2019-08-19 11:15:04.176948730 +0000
+++ gdb-8.3/gdb/osabi.c	2019-08-19 11:13:43.202284584 +0000
@@ -63,7 +63,7 @@ static const struct osabi_names gdb_osab
 
   { "SVR4", NULL },
   { "GNU/Hurd", NULL },
-  { "Solaris", NULL },
+  { "Solaris", "solaris[2-9]\.[0-9][0-9]" },
   { "GNU/Linux", "linux(-gnu[^-]*)?" },
   { "FreeBSD", NULL },
   { "NetBSD", NULL },
--- gdb-8.3/gdb/compile/compile.c	2019-08-19 13:07:57.669785758 +0000
+++ gdb-8.3/gdb/compile/compile.c	2019-08-19 13:07:33.865626973 +0000
@@ -697,7 +697,7 @@ compile_to_object (struct command_line *
       const char *arch_rx = gdbarch_gnu_triplet_regexp (gdbarch);
 
       /* Allow triplets with or without vendor set.  */
-      triplet_rx = std::string (arch_rx) + "(-[^-]*)?-" + os_rx;
+      triplet_rx = std::string (arch_rx) + "(-[^-]*)?-" + (os_rx ? : "");
       compiler->set_triplet_regexp (triplet_rx.c_str ());
     }
 

             reply	other threads:[~2019-09-06 13:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06 13:37 libor.bukata [this message]
2019-09-06 16:42 ` Keith Seitz
2019-09-06 17:11   ` libor.bukata
2019-09-09 17:56     ` Tom Tromey
2019-09-09  8:07 ` Rainer Orth
2019-09-09  8:57   ` libor.bukata
2019-09-10  9:18     ` Rainer Orth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ad99625-43ff-a450-6e50-d83242224443@oracle.com \
    --to=libor.bukata@oracle.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox