From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118042 invoked by alias); 10 Sep 2019 09:18:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118034 invoked by uid 89); 10 Sep 2019 09:18:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:966 X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Sep 2019 09:18:31 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 594A8F8C; Tue, 10 Sep 2019 11:18:29 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8jazENAEaJc6; Tue, 10 Sep 2019 11:18:28 +0200 (CEST) Received: from itzacchiuatl.CeBiTec.Uni-Bielefeld.DE (itzacchiuatl.CeBiTec.Uni-Bielefeld.DE [129.70.161.157]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 26058EC4; Tue, 10 Sep 2019 11:10:30 +0200 (CEST) Received: (from ro@localhost) by itzacchiuatl.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id x8A9ATf6002649; Tue, 10 Sep 2019 11:10:29 +0200 (CEST) From: Rainer Orth To: libor.bukata@oracle.com Cc: gdb-patches@sourceware.org Subject: Re: Fix a crash in compile_to_object function References: <3ad99625-43ff-a450-6e50-d83242224443@oracle.com> <2e87a0b1-c3eb-300f-cdf3-1cf3c2963c2b@oracle.com> Date: Tue, 10 Sep 2019 09:18:00 -0000 In-Reply-To: <2e87a0b1-c3eb-300f-cdf3-1cf3c2963c2b@oracle.com> (libor bukata's message of "Mon, 9 Sep 2019 10:55:37 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00155.txt.bz2 Hi Libor, > I noticed it from the testsuite results (crash dump generated) for gdb > 8.3. Although it is not implemented for Solaris, it should not crash, which > is the reason why I sent a patch that resolves a nullptr dereference. The > patched gdb prints an error message (instead of crashing) and the user can > continue with debugging. I agree with you that there many more pressing > issues that needs to be resolved first. that explains why I'm not seeing this in my gdb builds: I use a 32-bit-default gcc 9.1 to build a 64-bit gdb, so there's no matching libcc1.so around and the affected tests are UNTESTED. Fully agreed that there should be no crashes even for unsupported features, of course. I'll leave the actual review to the responsible maintainers. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University