From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix /proc pathname sizes on Solaris
Date: Wed, 19 Sep 2018 13:28:00 -0000 [thread overview]
Message-ID: <ydd8t3xhb0x.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <87k1nhr6e7.fsf@tromey.com> (Tom Tromey's message of "Wed, 19 Sep 2018 06:58:08 -0600")
Hi Tom,
>>>>>> "Rainer" == Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
>
> Rainer> - sprintf (pi->pathname, "/proc/%05d/lwp/%d", pid, tid);
> Rainer> + sprintf (pi->pathname, "/proc/%d/lwp/%d", pid, tid);
>
> FWIW gdb has xsnprintf which will check the length. Or I suppose it
> wouldn't be hard to just change this to be a std::string and not worry
> about lengths.
ah, good point. I'd forgotten about that here, but it's already fixed
in a largish procfs.c cleanup patch which gets rids of tons of ARI
warnings among others. Currently retesting...
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2018-09-19 13:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 14:11 Rainer Orth
2018-09-17 18:35 ` Joel Brobecker
2018-09-17 19:27 ` Rainer Orth
2018-09-19 9:04 ` Rainer Orth
2018-09-19 13:21 ` Joel Brobecker
2018-09-19 12:58 ` Tom Tromey
2018-09-19 13:28 ` Rainer Orth [this message]
2018-09-19 15:16 ` Pedro Alves
2018-09-19 17:42 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ydd8t3xhb0x.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox