From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29299 invoked by alias); 19 Sep 2018 13:28:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29287 invoked by uid 89); 19 Sep 2018 13:28:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=forgotten X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Sep 2018 13:28:19 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id E7889CDD; Wed, 19 Sep 2018 15:28:16 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Y0ZCb3NbTQw1; Wed, 19 Sep 2018 15:28:15 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id BB3FECDC; Wed, 19 Sep 2018 15:28:15 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id w8JDSErS021090; Wed, 19 Sep 2018 15:28:14 +0200 (MEST) From: Rainer Orth To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix /proc pathname sizes on Solaris References: <87k1nhr6e7.fsf@tromey.com> Date: Wed, 19 Sep 2018 13:28:00 -0000 In-Reply-To: <87k1nhr6e7.fsf@tromey.com> (Tom Tromey's message of "Wed, 19 Sep 2018 06:58:08 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00682.txt.bz2 Hi Tom, >>>>>> "Rainer" == Rainer Orth writes: > > Rainer> - sprintf (pi->pathname, "/proc/%05d/lwp/%d", pid, tid); > Rainer> + sprintf (pi->pathname, "/proc/%d/lwp/%d", pid, tid); > > FWIW gdb has xsnprintf which will check the length. Or I suppose it > wouldn't be hard to just change this to be a std::string and not worry > about lengths. ah, good point. I'd forgotten about that here, but it's already fixed in a largish procfs.c cleanup patch which gets rids of tons of ARI warnings among others. Currently retesting... Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University