Re: [PATCH] Fix /proc pathname sizes on Solaris

Rainer Orth
2018-09-19T17:42:18Z

Hi Pedro,

> On 09/17/2018 03:11 PM, Rainer Orth wrote:
>> * AFAIK Oracle has a corporate copyright assignment on file, so the
>> patches should be covered.
>
> It is my understanding that an assignment alone is not sufficient.
> The patches should be willfully contributed somehow too. The most
> common form is by the author or representative contributing or
> disclaiming it on the list of course.

I wasn't aware of that. In case any of the remaining patches from the
solaris-userland repo prove fit for submission, I'll check how this can
be done, given that the authors are no longer with Oracle.

>> Even if that were not the case, this one
>> and the next are certainly below the 15-line limit for non-trivial
>> patches.
>
> That certainly helps.

On top of that, both patches clearly document the intent already:

$ head 001-fix-proc-name-size.patch
#
# Fix the size of the pathname for /proc files.
# In Solaris, PID_MAX is 999999 (6 digit pid).
# In Solaris, lwpid_t is an unsigned int, so theoretically the lwp id
# could be 10 digits.
# Patch will be submitted upstream.

$ head 007-solib-svr4.patch
# Patch required for Solaris.
# Will contribute upstream if possible.